- Koha-bugs - lists.koha-community.org

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick(a)bywatersolutions.com --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #112 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Does the followups require all the fields to be retested? And put back the patch to "Needs Signoff". TODO wait answer, blocking question Imo we can keep the signed off state. Please adjust the last follow-up and let me finish QA on friday(?). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #111 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- - - "Any of these characters can be used as a separator between integer and decimal parts in the price fields. To work well with thousands separators you must (usually) choose between dot and comma to avoid ambiguity. So thousands separators come at the expense of handling both dots and commas. It you want to format price output, please use the system preference 'CurrencyFormat'" + - "Any of these characters can be used as a separator between integer and decimal parts in the decimal number fields that use the associated normalizing/unformatting mechanism. To also use thousands separators you must choose between dot and comma to avoid ambiguity. So using thousands separators comes at the expense of handling both dots and commas as decimal separators. This means reserving one character for decimal separation and another for thousands separation. So you must not use characters from the DecimalSeparators preference also as thousands separator. Also, if you want to format price output, please use the system preference 'CurrencyFormat'" The second description is imo too long. Let me try to suggest something shorter: Any of these characters can be used as a separator between integer and decimal part of a price field. To avoid ambiguity, do not use the same characters as thousands separator. Use pref CurrencyFormat to format price ouput. => Instead of the cryptic "fields that use the associated normalizing/unformatting mechanism", you might add something like: (This pref is currently used on the patron fines tab.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6828] Add Admin Dashboard for staff users.
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #28 from Cab Vinton <bibliwho(a)gmail.com> --- (In reply to Jonathan Druart from comment #22) > Did you test the rebase patches? So I've learned how to sign off on patches, but the status of this patch is Failed QA. If a dashboard XML file needs to be created, then not sure whether testing via a sandbox would work. Tried Sandbox 06 anyway & got the following: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 6828: <h1>Something went wrong !</h1>Applying: Bug 6828[ENH] - Add basic Dashboard for staff users. .git/rebase-apply/patch:483: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Auth.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref M koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt M mainpage.pl .git/rebase-apply/patch:483: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging mainpage.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 6828[ENH] - Add basic Dashboard for staff users. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 6828 - Add Admin Dashboard for staff users. 10217 - [SIGNED-OFF] Bug 6828[ENH] - Add basic Dashboard for staff users. 10218 - [SIGNED-OFF] Bug 6828 follow-up: adapt dashboard to new staff client theme 60692 - Bug 6828[ENH] - Add basic Dashboard for staff users. 60693 - Bug 6828 follow-up: adapt dashboard to new staff client theme Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/SIGNED-OFF-Bug-6828ENH---Add-basic-Dashboard-for-s-EpoHfa.patch . -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 19519] New: Ability to bind the rotating collection with branch during creating
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519 Bug ID: 19519 Summary: Ability to bind the rotating collection with branch during creating Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 76625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76625&action=ed… Bug 7547: (RM follow-up) Compiled css -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 76624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76624&action=ed… Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '18

02 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76491|0 |1 is obsolete| | Attachment #76492|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 76623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76623&action=ed… Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0