- Koha-bugs - lists.koha-community.org

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #11 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76492&action=ed… Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76418|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76491&action=ed… Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7547] Printing a sorted cart
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec(a)gmail.com CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 76489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76489&action=ed… Bug 10659: (follow-up) Compiled CSS This patch contains the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 76488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76488&action=ed… Bug 10659: (follow-up) Add plugin information to the about page This patch updates the about page in the staff client, replacing the information about the jQuery Star Ratings plugin with information about the new jQuery Bar Ratings plugin. To test, apply the patch and go to the about page in the staff client. Confirm that the new information appears correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76049|0 |1 is obsolete| | Attachment #76050|0 |1 is obsolete| | Attachment #76051|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 76487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76487&action=ed… Bug 10659: Upgrade jQuery star ratings plugin This patch replaces our current jQuery star ratings plugin with a newer plugin which will be compatible with newer versions of jQuery: http://antenna.io/demo/jquery-bar-rating/examples/ To test you should have one or more records in your catalog with star ratings. - Apply the patch and set the OpacStarRatings system preference to "results and details" - Perform a search in the catalog which will return one or more titles which have ratings. - Confirm that the ratings appear correctly and the ratings are read-only. - Open the "normal" detail page for that record. - Confirm that the star rating appears correctly. - Test setting and re-setting your star rating. Confirm that it is saved. - Confirm that the "cancel rating" link appears when you have a rating set, and that it disappears after you click it. - Test that the "only details" and disabled options of the OpacStarRatings preference work as they should. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20744] New: Replace staff client header Koha logo gif with transparent png
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20744 Bug ID: 20744 Summary: Replace staff client header Koha logo gif with transparent png Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The Koha logo in the staff client header area is a transparent gif which doesn't look good if you style the background of that area with different colors. It should be replaced with a png image with alpha transparency. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 18973] New: Auto focus the ISBN field
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 Bug ID: 18973 Summary: Auto focus the ISBN field Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs(a)lists.koha-community.org Reporter: fv(a)spots.school QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Created attachment 65192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65192&action=ed… patch Code that focuses the ISBN field. This saves a mouse click or two tabs when entering ISBNs for searching. Patch attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 19820] New: Add unsafe param to GetMarcSubfieldStructure
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Bug ID: 19820 Summary: Add unsafe param to GetMarcSubfieldStructure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org GetMarcStructure has an "unsafe" param for faster cache retrieval, I have looked through all the instances where GetMarcSubfieldStructure is called, and seems to me it's safe to call get_from_cache with the "unsafe" option also in those cases. While profiling Koha I found that quite some time was actually spent deserializing MarcSubfieldStructure-hashes (that are usually pretty big), actually around 7% of total time while indexing biblios for example. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28