- Koha-bugs - lists.koha-community.org

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #48 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #43) > QA Comment: > > Why do you add in catalogue/search.pl: > +use String::Random; > > +@results_per_page_options = do { my %seen; grep { !$seen{$_}++ } > @results_per_page_options }; > Could you 'do' this without a do statement? Do you need uniq from List::More > ? > Is it really needed btw? Do you expect duplicate numbers in this pref.. > This is now gone in latest follow-up. > results.tt > Why are you changing the lines with respect to list counts? What is the > relation with this patch? > This seems unrelated to this patch but is no longer affected in the follow-up. > opac-search.pl > -$offset = ($page-1)*$results_per_page if $page>1; > Why do you remove it ? > Offset is dealt with later. > - ($error, $results_hashref, $facets) = > C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers, > $results_per_page,$offset,$expanded_facet,undef,$query_type,$scan); > + ($error, $results_hashref, $facets) = > C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers, > $results_per_page,$offset,$expanded_facet,$query_type,$scan); > You remove a undef parameter. > Why? Is this a bug on its own? What is the relation with this report? > > Please clarify or adjust. Have put undef param back. Not sure why this was removed initially. Ready for testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #47 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75941&action=ed… Bug 14715: [FOLLOW-UP] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68327|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75940&action=ed… Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol <simon.pouchol(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68001|0 |1 is obsolete| | --- Comment #45 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75939&action=ed… Bug 14715: [FOLLOW-UP] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68000|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75938&action=ed… Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14593] Send notifications for pending staff actions (moderation, suggestions)
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '18

10 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14593 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19412 CC| |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14814] Suggestions improvements
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '18

10 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14814 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Vitor, taking a look here: 1) It's possible to add suggestions for a patron from the patron account. 2) Still valid. 3) It's now possible to order by email from the basket. I thin 1) is solved, 2) an 3) are still partially valid, but they shoud go on separate bug reports. Bugs too general will be overlooked easily and those are very different features that would have to be resolved with 2 patch sets any way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13533] Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '18

10 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13484 -- You are receiving this mail because: You are watching all bug changes.

1 0