- Koha-bugs - lists.koha-community.org

[Bug 28857] New: Allow hold to be suspended at point of creation
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28857 Bug ID: 28857 Summary: Allow hold to be suspended at point of creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Holds with a future start date and an element of complexity that some libraries would like to avoid. Instead, they use suspensions to delay the fulfilling of holds. However, there's no way to suspend a hold as you place it -- you need to place the hold and then suspend it from another screen. We should make it possible to set a suspension on a hold as you place it. But we should make is easy to hide the option to do so, so this probably means a new system preference, something like SuspendHoldsAtCreation, with options for No / Intranet / OPAC / Both Intranet and OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #81 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- OK.. I've done an internal code review here and added some follow-ups and fixes of my own. I've added my signoff lines and the sponsor lines, but I've not set to signed off as I'm also OpenFifth (this was an internal code review only) and it needs thorough testing by some third party end users. I'm pushing for a proper librarian facing test plan at the moment. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #80 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193755&action=e… Bug 14962: (QA follow-up) Fix silent failures and dead code in DisplaysResource Two issues in DisplaysResource.vue: 1. The error handlers for create() and update() in onFormSave were empty, so API failures (422, 500, etc.) produced no feedback to the user. Use the already-injected setError to show an error message. 2. An empty onBeforeMount(() => {}) lifecycle hook with its corresponding import was left over from development. Remove the dead code. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #79 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193754&action=e… Bug 14962: (QA follow-up) Add missing vue.css import to display module All other Vue modules (preservation, erm, acquisitions) import vue.css for Vue-specific UI styles. The display module omitted it, which could result in missing styles for dialogs and form elements. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #78 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193753&action=e… Bug 14962: (QA follow-up) Use dt_from_string instead of DateTime->today in Displays->active DateTime->today uses the system timezone rather than the Koha-configured timezone, which can cause incorrect date comparisons for libraries that configure a timezone different from the server's local time. Use Koha::DateUtils::dt_from_string, which is the standard Koha convention and is consistent with every other date comparison in this feature. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #77 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193752&action=e… Bug 14962: (QA follow-up) Use correct displays permission flag in API tests All 'authorized librarian' test users in displays.t and displayitems.t were created with flags => 1 (superlibrarian), which bypasses all permission checks. The comment said "displays permission" but bit 0 is the superlibrarian flag. The displays module is userflags bit 33, so use flags => 2**33 to actually test that the displays flag grants access. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #76 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193751&action=e… Bug 14962: (QA follow-up) Fix display_name type and required mismatch in OpenAPI definition The database defines display_name as varchar(255) DEFAULT NULL (nullable), but the OpenAPI definition declared it as a non-nullable string and listed it in the required array. This contradicted the schema. Allow null for display_name and remove it from required to match the actual database column definition. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #75 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193750&action=e… Bug 14962: (QA follow-up) Change branch/itype FK on displays to ON DELETE SET NULL The foreign keys from displays.display_branch, display_holding_branch, and display_itype used ON DELETE CASCADE, which would silently delete entire displays when an admin removes a branch or item type. These columns are optional configuration references, not ownership relationships (all are nullable DEFAULT NULL). Use ON DELETE SET NULL so the display is preserved and the reference is simply cleared, which is consistent with how items.homebranch references branches. Update atomicupdate, kohastructure.sql, and the DBIC schema to match. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #74 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193749&action=e… Bug 14962: (QA follow-up) Set bug_number in atomicupdate script The bug_number field was left as an empty string. The Koha installer framework uses this field to track which database updates have been applied and to report status. Set it to 14962. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '26

24 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #73 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193748&action=e… Bug 14962: (QA follow-up) Remove display_type filter parameter with no backing field The display_type query parameter was declared on both GET /displays and GET /public/displays but there is no display_type column in the displays table, no such property in the schema definition, and no accessor in the DBIC schema. Remove the parameter to avoid confusing API consumers. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0