- Koha-bugs - lists.koha-community.org

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #13) > I am sorry, but this doesn't work for me. Heh, UI changes distracted me a bit apparently :) Fixed now. (In reply to Katrin Fischer from comment #14) > Was this intentional? > + use Data::Printer colored => 1; warn p $subscription; Of course not, removed. > If possible I think the success message for batch renewal would be better > without the pop-up and just on the page above the table with the usual > markup. I would consider that out of the scope, I think it has been improved with bug 20614 and the confirmation popup. It would require a complete rewrite of this script to make it work better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74541&action=ed… Bug 7910: Give feedack when the subscriptions have been renewed - useless? This patch adds a message to the user to let them know the subscription have been renewed successfully. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74501|0 |1 is obsolete| | Attachment #74502|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74540&action=ed… Bug 7910: Add the ability to renew several subscriptions at once This patch adds a "Renew all selected subscriptions" action link on top of the table of the "Check expiration" page. It will allow to auto-renew several subscriptions. Test plan: Make sure this new link renew the selected subscriptions as expected. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74526|0 |1 is obsolete| | --- Comment #75 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74529&action=ed… Bug 12310: Follow up to prevent updatedatabase noise Added IGNORE into the SQL statement. TEST PLAN --------- run the atomic update multiple times. -- noise apply patch run the atomic update multiple times. -- no noise Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74525|0 |1 is obsolete| | --- Comment #74 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74528&action=ed… Bug 12310 : Follow up to keep the example text in fines This puts the example text back in with the correct decimal separator. The example uses the first char of the syspref. TEST PLAN --------- 1) set the I18N/L10N DecimalSeparators syspref to "," 2) go to a patron's fines tab. 3) open Create manual invoice and Create manual credit tabs 4) check both tabs -- Example: 5.00 appears 5) apply this patch 6) reload the page and check both create tabs. -- Example: 5,12 appears 7) set the I18N/L10N DecimalSeparators syspref to ".," 8) go back and check both tabs. -- Example: 5.12 appears (only the first separator is picked) 9) optionnal: run koha qa test tools Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74524|0 |1 is obsolete| | --- Comment #73 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74527&action=ed… Bug 12310 : Decimal separator issues: fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DecimalSeparators syspref. - minuses, doesn't remove them - non-decimal values: it doesn't touch them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, truncation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34€hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. 🐨🐨🐨 Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73880|0 |1 is obsolete| | --- Comment #72 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74526&action=ed… Bug 12310: Follow up to prevent updatedatabase noise Added IGNORE into the SQL statement. TEST PLAN --------- run the atomic update multiple times. -- noise apply patch run the atomic update multiple times. -- no noise Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73874|0 |1 is obsolete| | --- Comment #71 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74525&action=ed… Bug 12310 : Follow up to keep the example text in fines This puts the example text back in with the correct decimal separator. The example uses the first char of the syspref. TEST PLAN --------- 1) set the I18N/L10N DecimalSeparators syspref to "," 2) go to a patron's fines tab. 3) open Create manual invoice and Create manual credit tabs 4) check both tabs -- Example: 5.00 appears 5) apply this patch 6) reload the page and check both create tabs. -- Example: 5,12 appears 7) set the I18N/L10N DecimalSeparators syspref to ".," 8) go back and check both tabs. -- Example: 5.12 appears (only the first separator is picked) 9) optionnal: run koha qa test tools Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0