- Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71946|0 |1 is obsolete| | --- Comment #81 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73907&action=ed… Bug 15395: Make Koha::I18N work with Plack + add tests Language detection was done in a BEGIN block so it was not working correctly with Plack. This is now done when the first translation is requested. This patch also fixes a bug when set_locale(LC_ALL, ...) fails for some reasons (locale is not installed system-wide for example). And finally, add some unit tests Test plan: 1. prove t/Koha/I18N.t 2. Replay the previous test plans with plack enabled Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71945|0 |1 is obsolete| | --- Comment #80 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73906&action=ed… Bug 15395: Fix output of msgcat By default, msgcat tries to merge translations when two or more files have the same msgid, even for the header (msgid ""). This resulted in an invalid PO file ("#-#-#-#-#" markers in header). This patch tells msgcat to use the first available translation instead. Also, this patch set correctly the Project-Id-Version field Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71944|0 |1 is obsolete| | --- Comment #79 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73905&action=ed… Bug 15395: Fix PO header reading in po2json Since version 0.24 Locale::PO do not escape newline characters in string returned by dequote() This patch set the required version of Locale::PO to 0.24 and fix po2json https://rt.cpan.org/Public/Bug/Display.html?id=96016 Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71943|0 |1 is obsolete| | --- Comment #78 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73904&action=ed… Bug 15395: Exclude xslt from the list of themes when building locale_data.js Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71942|0 |1 is obsolete| | --- Comment #77 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73903&action=ed… Bug 15395: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian stable, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71941|0 |1 is obsolete| | --- Comment #76 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73902&action=ed… Bug 15395: Plural translations in templates Provides a way to handle translation of plural forms in templates Add Template::Toolkit plugin for Koha::I18N Use like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Add dependency to PPI Test plan: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71940|0 |1 is obsolete| | --- Comment #75 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 73901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73901&action=ed… Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. The PO file moves from misc/translator/po/xx-XX-messages.po to misc/translator/po/xx_XX/LC_MESSAGES/Koha.po and now needs to be compiled to MO in order to be used by Koha. Compilation of PO file is done by running: ./translate install xx-XX Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages Test plan: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) You will need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #73 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt FAIL forbidden patterns forbidden pattern: tab char (line 110) OK git manipulation OK spelling OK tt_valid OK valid_template FAIL t/db_dependent/Breeding.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't locate t/luib/Mocks.pm in @INC (you may need to install the t::luib::Mocks module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) Typo in the test file? Please fix! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |julian.maurice(a)biblibre.com --- Comment #132 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #131) > (In reply to ByWaterSandboxes from comment #130) > > It does not affect messages in the message_queue. > > So it's not "all emails" :) > I was going to fail QA this patch because I was testing overdue notices. > > However it seems that is was the first intention of this patch (see first > patch, in comment 3). Why did you change your mind? This comment needs an answer. Changing status to In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '18

10 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've tried it with the example from the commit message in Firefox and Chromium and no problems found (without patch). Maybe something is missing from the test plan? -- You are receiving this mail because: You are watching all bug changes.

1 0