- Koha-bugs - lists.koha-community.org

[Bug 19996] New: use Modern::Perl in cataloguing perl scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Bug ID: 19996 Summary: use Modern::Perl in cataloguing perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl use Modern::Perl should be used instead of use strict; use warnings; Relevant in: addbiblio.pl addbooks.pl additem.pl linkitem.pl moveitem.pl value_builder/normarc_field_007.pl value_builder/normarc_field_008.pl value_builder/normarc_leader.pl value_builder/unimarc_field_010.pl value_builder/unimarc_field_100.pl value_builder/unimarc_field_105.pl value_builder/unimarc_field_106.pl value_builder/unimarc_field_110.pl value_builder/unimarc_field_115a.pl value_builder/unimarc_field_115b.pl value_builder/unimarc_field_116.pl value_builder/unimarc_field_117.pl value_builder/unimarc_field_120.pl value_builder/unimarc_field_121a.pl value_builder/unimarc_field_121b.pl value_builder/unimarc_field_122.pl value_builder/unimarc_field_123a.pl value_builder/unimarc_field_123d.pl value_builder/unimarc_field_123e.pl value_builder/unimarc_field_123f.pl value_builder/unimarc_field_123g.pl value_builder/unimarc_field_123i.pl value_builder/unimarc_field_123j.pl value_builder/unimarc_field_124.pl value_builder/unimarc_field_124a.pl value_builder/unimarc_field_124b.pl value_builder/unimarc_field_124c.pl value_builder/unimarc_field_124d.pl value_builder/unimarc_field_124e.pl value_builder/unimarc_field_124f.pl value_builder/unimarc_field_124g.pl value_builder/unimarc_field_125.pl value_builder/unimarc_field_125a.pl value_builder/unimarc_field_125b.pl value_builder/unimarc_field_126.pl value_builder/unimarc_field_126a.pl value_builder/unimarc_field_126b.pl value_builder/unimarc_field_127.pl value_builder/unimarc_field_128a.pl value_builder/unimarc_field_128b.pl value_builder/unimarc_field_128c.pl value_builder/unimarc_field_130.pl value_builder/unimarc_field_135a.pl value_builder/unimarc_field_140.pl value_builder/unimarc_field_141.pl value_builder/unimarc_field_210c.pl value_builder/unimarc_field_210c_bis.pl value_builder/unimarc_field_225a.pl value_builder/unimarc_field_4XX.pl value_builder/unimarc_field_686a.pl value_builder/unimarc_field_700-4.pl value_builder/unimarc_leader.pl z3950_auth_search.pl z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 12227] Remove demo user functionality
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #65 from Nick Clemens <nick(a)bywatersolutions.com> --- Everything seesm to work as expected - I would consider putting a big warning on AuthorityControlledIndicators to specify you shouldn't touch it if you don't know what you are doing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #64 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73779&action=ed… Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #63 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73778&action=ed… Bug 14769: (Follow-up) Reduce number of preference parses In sub merge the Koha::Authority object was already created, so it was kind of silly to recreate it each time with new. In Koha::Authority, the ControlledIndicators object can be saved in the object too for reuse during its life time. Similarly, we prevent repeated lookups for the reporting tag (via authority type). Test plan: [1] Run t/db_dependent/Authority/Merge.t [2] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Limited benchmarking shows me a reduction of 11% on Merge.t and a reduction of 4% on Authorities.t when comparing with and without this last patch. The larger impact on Merge.t could be expected. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #62 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73777&action=ed… Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #61 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73776&action=ed… Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #60 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73775&action=ed… Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #59 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73774&action=ed… Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72398|0 |1 is obsolete| | Attachment #72399|0 |1 is obsolete| | Attachment #72400|0 |1 is obsolete| | Attachment #72401|0 |1 is obsolete| | Attachment #72402|0 |1 is obsolete| | Attachment #72403|0 |1 is obsolete| | Attachment #73389|0 |1 is obsolete| | --- Comment #58 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73773&action=ed… Bug 14769: Introduce Koha::Authority::ControlledIndicators This module reads its settings from pref AuthorityControlledIndicators. The get method allows you to retrieve indicator values for specific biblio fields. Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Amended: Added a test to show that "ind1:" returns empty string. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0