- Koha-bugs - lists.koha-community.org

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68853|0 |1 is obsolete| | --- Comment #54 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 72957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72957&action=ed… Bug 15261 - Check reserves while renewing an issue Test plan: - Create an issue (i.e from 15/09/2017 to 04/10/2017), - place a reserve on the same item from 05/10/2017 to 30/10/2017), - enable PreventCheckoutOnSameReservePeriod, - Check that you are not able to renew the issue. Rebased (2018-03-15) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68852|0 |1 is obsolete| | --- Comment #53 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 72956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72956&action=ed… Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rabased on master Rebased on master (2016-06-23) Rebased on master (2017-03-23) Rebased on master (2018-03-15) Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12011] ReservesNeedReturns breaks 'Hold Filled' functionality
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12011 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20423 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 George Williams (NEKLS) <george(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george(a)nekls.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #47 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- - 1.1 - 1.000,6 → 1 with syspref ",." - 1.000,6 → 1000.6 with syspref "," - .6, - 0 - 1,346.55 → 1.346.55 with syspref ",." - 1,346.55 → 1346.55 with syspref "," So syspref needed to have support of thousands separators at the expense of supporting both . and , as decimal one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10449] Suggestions pending approval should count only suggestions of current branch
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #24 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Will be fixed on Bug 18743 *** This bug has been marked as a duplicate of bug 18743 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #46 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- some QA feedback: - enforce JS9 coding guideline - JS10: use JQuery validation https://gitlab.com/koha-community/Koha/blob/master/koha-tmpl/intranet-tmpl/… - it might be acceptable to not have JS form validation (as there is none now). Is there is, it could be a follow up bug. - test if there is server-side validation. Check at least what happens. - "T_T" - "11.34,45.5" - "madness12.34" - "12.34nooooo" - "lol12.34why" - "1.000,000.56" - "1,000.000,56" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10449] Suggestions pending approval should count only suggestions of current branch
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18743 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #45 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- After talking to cait: must support thousands separators After talking to BULAC and Lyon 3 and at least 2 other libraries: must support multiple decimal separators in **the same instance** (12.56 and 12,56 → 12.56) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9692] Add a checkbox to display statistical fields in basket.tt
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr --- Comment #12 from Séverine Queune <severine.queune(a)bulac.fr> --- Second patch doesn't apply. Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9692-FOLLOWUP-Add-a-checkbox-to-display-statis-W5i0Tj.patch -- You are receiving this mail because: You are watching all bug changes.

1 0