- Koha-bugs - lists.koha-community.org

[Bug 12460] Search history: Combine to start a new search
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucie.gay@ens-paris-saclay. | |fr --- Comment #24 from Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> --- Some comments about my test : 6. "Start a new search" is now enabled, click it. -> "Start a new search" doesn't appear. 7. A dropdown list appears, asking you to chose between a "Match any" search and a "Match all" search. There is also a new column in the table ("Not") allowing you to apply a NOT to the corresponding line 8. Make your choice, and then click on Go button, next to the dropdown list. You will be redirected to the catalogue search results. -> Instead, there is a simple text box and a button "Combine queries". 9. Confirm that the results are correct. -> Launch a new search with combination of IDs works well (for example : #1 AND #2) and generate a new line in the history search. 10. Set syspref opacthemes to 'bootstrap' -> During the test, bootstrap was already assigned to syspref opacthemes. 11. Go to OPAC interface anonymously and repeat steps 2-9 -> When we are logged, the IDs of search are simple (#1), but when we are not logged the IDs looks like (#2018312170988) 12. Login to OPAC interface and repeat steps 2-9 13. Check that authority search history still works as before the patch (except that there is only one table instead of two) -> There are still two tabs in the search history : catalog / authority. So it's not easy to combine both. In the authority's tab, there is no option "combine queries". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15595] Display Google Jacket image on staff client search list and detail page
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset(a)biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- conflict: ~/d/koha ❯❯❯ git bz apply 15595 Bug 15595 - Display Google Jacket image on staff client search list and detail page 70721 - Bug-15595: Google cover staff search and detail Apply? [(y)es, (n)o, (i)nteractive] y Application de Bug-15595: Google cover staff search and detail .git/rebase-apply/patch:45: trailing whitespace. warning: 1 ligne a ajouté des erreurs d'espace. Utilisation de l'information de l'index pour reconstruire un arbre de base... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt .git/rebase-apply/patch:45: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Retour à un patch de la base et fusion à 3 points... Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt CONFLIT (contenu) : Conflit de fusion dans koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLIT (contenu) : Conflit de fusion dans koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Fusion automatique de installer/data/mysql/sysprefs.sql error: Échec d'intégration des modifications. le patch a échoué à 0001 Bug-15595: Google cover staff search and detail La copie du patch qui a échoué se trouve dans : .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15595-Google-cover-staff-search-and-detail-YnkBAW.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15595] Display Google Jacket image on staff client search list and detail page
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 Claude <claude.brayer(a)cea.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claude.brayer(a)cea.fr Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71319|0 |1 is obsolete| | --- Comment #52 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72709&action=ed… Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20098] New: Inventory: CSV export: itemlost column is always empty
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Bug ID: 20098 Summary: Inventory: CSV export: itemlost column is always empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org It's mapped with the name "lost" instead of "itemlost" == Reproduce == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" → "items.itemlost" → "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Maksim Sen <maksim.sen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Maksim Sen <maksim.sen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68214|0 |1 is obsolete| | --- Comment #64 from Maksim Sen <maksim.sen(a)inlibro.com> --- Created attachment 72706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72706&action=ed… Bug 12747 - Add extra column in Z3950 search This is a complete squash of previous patches, with additional code quality improvments following M. Tompsett's feedback. Squashing was done (as suggested) because many lines add be added and subsequently deleted, which made for confusing patches. New changes: * Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_ variable is no longer used (at all), and the split() routine is used. * t/db_dependent/Breeding.t now uses the mocked preference logic to avoid sysprefs being affected. Functionality and test plan have not changed. -- This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields Sponsored-by: CCSR (https://ccsr.qc.ca) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Maksim Sen <maksim.sen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5620] Capture Mode of payment
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've tested paying in different variations, but it only appears to work for one option: 1) Pay button next to fine = pull down works 2) Pay selected = doesn't offer the pull down (FAIL) 3) Pay amount = doesn't offer the pull down (FAIL) Am I confusing something here? Other things: - account_offsets only lists "Payment" - should we list the type of payment there? What about partial payments where one part is paid with one mode of payment and the other part with another? - Should we consider preselecting Cash or make Other = Not specified or similar? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5620] Capture Mode of payment
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #40 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 69002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69002 Bug 5620 - (Rebase) - Collect payment mode in staff interface Review of attachment 69002: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=562…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +156,5 @@ > + <option value="04">Credit card</option> > + <option value="05">Debit</option> > + <option value="08">Paypal</option> > + <option value="06">Check</option> > + <option value="07">Cryptocurrency</option>\ The dash here at the end is superfluous. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0