- Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71262|0 |1 is obsolete| | --- Comment #185 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72071&action=ed… Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71261|0 |1 is obsolete| | --- Comment #184 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72070&action=ed… Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71260|0 |1 is obsolete| | --- Comment #183 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72069&action=ed… Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |magnus(a)libriotech.no -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #4 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 72066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72066&action=ed… Bug 11936 - Consistent log message for item insert If you use bulkmarcimport.pl to import records with items it looks like the successfull insert of the record is reported multiple time, but the second and subsequent "ok" is really related to importing the item(s). This patch changes the log message on successfully inserting an item to match the log message given when inserting an item fails. To test, the easy way: - Look at lines 530 and 536 of bulkmarcimport.pl, and note that the "op" in those two lines are different - Apply the patch - Look at lines 530 and 536 again, and note that the "op" is now identical, and that this makes sense, since they are both related to the same operation, specifically inserting an item To test, the hard way - Have some records with items - Import the records with bulkmarcimport.pl, and make sure to specify the -l option, to create a log of the actions taken - Look at the log and verify it looks something like this: id;operation;status 1;insert;ok 1;insert;ok 2;insert;ok 2;insert;ok - Apply this patch and import some more records with items. The log should now be similar to this: id;operation;status 1;insert;ok 1;insertitem;ok 2;insert;ok 2;insertitem;ok -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15364] fines and invoices in letter templates
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15364 Ola Andersson <ola.andersson(a)ltu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ola.andersson(a)ltu.se -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

1 0

[Bug 11936] Different log messages for biblio insert and item insert in bulkmarcimport.pl log
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #3 from Magnus Enger <magnus(a)libriotech.no> --- Or rather op=>"insertitem", to match line 530. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Different log messages for biblio insert and item insert in bulkmarcimport.pl log
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #2 from Magnus Enger <magnus(a)libriotech.no> --- This is the code that needs to be changed: 527 eval { ( $itemnumbers_ref, $more_errors ) = AddItemBatchFromMarc( $record, $biblionumber, $biblioitemnumber, '' ); }; 528 if ( $@ ) { 529 warn "ERROR: Adding items to bib $biblionumber failed: $@\n"; 530 printlog({id=>$id||$originalid||$biblionumber, op=>"insertitem",status=>"ERROR"}) if ($logfile); 531 # if we failed because of an exception, assume that 532 # the MARC columns in biblioitems were not set. 533 ModBiblioMarc( $record, $biblionumber, $framework ); 534 next RECORD; 535 } else { 536 printlog({id=>$id||$originalid||$biblionumber, op=>"insert",status=>"ok"}) if ($logfile); 537 } It would be clearer if line 536 had something like op=>"insert item" -- You are receiving this mail because: You are watching all bug changes.

1 0