- Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #148 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259&action=ed… Bug 14385: A lot of patches - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #147 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70258&action=ed… Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #146 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70257&action=ed… Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #145 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70256&action=ed… Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #165 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've taken a look at the patches for a first QA review. 1) Currently fails QA script: FAIL t/db_dependent/Koha/Patrons/Import.t FAIL critic "$headerrow_0" is declared but not used at line 320, column 5. Unused variables clutter code and make it harder to read. 2) Tests fail: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/Koha/Patrons/Import.t 1..124 ok 1 - use Koha::Patrons::Import; ok 2 - An object of class 'Koha::Patrons::Import' isa 'Koha::Patrons::Import' # Subtest: test_methods 1..1 ok 1 - Koha::Patrons::Import->can(...) ok 3 - test_methods # Subtest: test_attributes 1..1 ok 1 - Koha::Patrons::Import->can(...) ok 4 - test_attributes ok 5 - Koha::Patrons::Import->import_patrons carps if no file handle is passed ok 6 - Got the expected undef from import_patrons with nothing much ok 7 - Koha::Patrons::Import->import_patrons carps if no file handle is passed ok 8 - Got the expected undef from import_patrons with no file handle Use of uninitialized value $matchpoint in string eq at /home/vagrant/kohaclone/Koha/Patrons/Import.pm line 170, <$handle_1> line 2. # Looks like your test exited with 255 just after 8. 3) Might be me, but trying to run the script always gives me the help, no error or anything. Used -c and -f with a random file. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- While a general solution for adding pages to the OPAC would be nice, I agree this would be a good addition. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13044] Deprecate old book drop mode
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 --- Comment #3 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I suppose we could make bookdrop mode find the last date open and recalculate the fine in full from there. That way it looks the same from a user perspective. The problem with bookdrop mode is that it is quite fragile. For example, if fines.pl doesn't run for a night, and does the following night, then using bookdrop mode will decrement the fine by double the expected amount. The backdating returns feature does not suffer from this kind of fragility. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10032] Uncertain prices hide 'close basket' without explanation
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69748|0 |1 is obsolete| | --- Comment #6 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Created attachment 70250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70250&action=ed… Bug 10032: Uncertain prices hide 'close basket' without explanation Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. To test: 1) Before applying the patch, go to staff UI, and select Acquisitions, pick one of your existing vendors (or create a new one) and then open a new basket (call it anything you want). 2) Add a new (empty) record order to the basket. 3) Give the new record a made up title, add a single item (no need to fill in any details), set a price of 10.00 and check the "Uncertain price" checkbox before saving the record. 4) Confirm that the resulting summary page has a button bar that does NOT include any button for closing the basket. 5) Modify the record and remove the check mark from the "Uncertain price" checkbox before saving. 6) Confirm that the resulting basket summary page button bar now does have a "Close this basket" button (as the basket no longer has uncertain prices). 7) Apply the patch. 8) Modify the record again to check the "Uncertain price" checkbox again, then save it. 9) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button but that this button is greyed out and inoperative. 10) Modify the record again to remove the check mark in the "Uncertain price" checkbox, then save the record. 11) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button which is now active (as the order no longer has an uncertain price). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0