- Koha-bugs - lists.koha-community.org

[Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '17

22 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am in doubt about adding a new routine to C4::GetOPACMarcNotes - We are missing tests, but tests are required for any new routine or a change to an existing one. - I think it might make more sense to use improve GetMarcNotes to take an interface parameter, like we do in other cases. Duplicating the code will create problems, such as with bug 18198. -- Some other small things: - Database update should be in an atomicupdate file (see database update instructions on the wiki) - Please use INSERT IGNORE - It might be a bit more consistent with other prefs to have OPACNotesBlackList. Examples: (OPAC)ISBD,(OPAC)AmazonCoverImages, (OPAC)LocalCoverImages, ...) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70086|0 |1 is obsolete| | --- Comment #128 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70087&action=ed… Bug 8000 - Redirect all emails to SendAllEmailsTo Koha/Email.pm Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #127 from Charles Farmer <charles.farmer(a)inlibro.com> --- With the latest patch reworked by David, I feel like this bug can be placed once again in "Needs Signoff". Rebased on the current master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67155|0 |1 is obsolete| | --- Comment #126 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70086&action=ed… Bug 8000 - Redirect all emails to SendAllEmailsTo Koha/Email.pm Test plan: 1) Apply path 2) Clear all SendAllEmailsTo system preference 3) Send mail to a patron of your choosing, email will go to patron's email address as usual. 4) Set SendAllEmailsTo to a test email address 5) Send mail to the patron, email will be redirected to the email set in the systempreference. It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70075&action=ed… Bug 15492 [QA Followup] - Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #12 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70074&action=ed… Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69664|0 |1 is obsolete| | Attachment #69665|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70073&action=ed… Bug 15492: Add the SelfCheckInModule syspref Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11976] Add column settings + new column "Publication date" to the subscription table
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11976] Add column settings + new column "Publication date" to the subscription table
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.

1 0