- Koha-bugs - lists.koha-community.org

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Lucas Gass (lukeg) <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Lucas Gass (lukeg) <lucas(a)bywatersolutions.com> --- Other things that need fixing: 1. [FAIL] installer/data/mysql/atomicupdate/bug-15248.pl FAIL file_permissions File must have the exec flag This needs the correct permission. 2. There is no DBIC/DO NOT PUSH commit. 3. FindDuplicateWithMatchingRules needs POD coverage 4. Koha/REST/V1/Biblios.pm is not tidy. 5. Koha/BiblioFrameworkMarcMatchers.pm: FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 --- Comment #21 from Lucas Gass (lukeg) <lucas(a)bywatersolutions.com> --- (In reply to Julian Maurice from comment #19) > Patch up-to-date and tidy > > (In reply to Lucas Gass (lukeg) from comment #17) > > /kohadevbox/koha/t/db_dependent/Search.t are also failing for me. > Tested again and it works for me. Can you add some details ? However, there is a failure: [FAIL] t/db_dependent/Search.t FAIL forbidden_patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 1402) No reason to not use dt_from_string here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 --- Comment #20 from Lucas Gass (lukeg) <lucas(a)bywatersolutions.com> --- (In reply to Julian Maurice from comment #19) > Patch up-to-date and tidy > > (In reply to Lucas Gass (lukeg) from comment #17) > > /kohadevbox/koha/t/db_dependent/Search.t are also failing for me. > Tested again and it works for me. Can you add some details ? Sorry, the test does pass. User error here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #77 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 192905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192905&action=e… Bug 3492: (follow-up) Replace GetReserveFee with holds_fee method GetReserveFee was removed as part of the migration to circulation rules-based hold fees, but reserve/request.pl still imported and used it, causing compilation errors. This patch replaces the two usages of GetReserveFee with the modern approach using Koha::Item->holds_fee($patron), matching the implementation in opac-reserve.pl. The fee is calculated by iterating through available items and using the first non-zero fee found, which provides backward compatibility with the legacy reserve_charge template variable. This implementation uses ReservesControlBranch to determine which branch's circulation rules apply (either item home library or patron home library), consistent with the existing Koha policy framework. Test plan: 1. Apply patch 2. Verify reserve/request.pl compiles: perl -wc reserve/request.pl 3. Navigate to staff interface holds page with patron and biblio 4. Verify hold fee is displayed correctly if configured in circulation rules 5. Place a hold and verify fee is charged correctly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #76 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 192904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192904&action=e… Bug 3492: (follow-up) Add missing TitleHoldFeeStrategy to sysprefs.sql The TitleHoldFeeStrategy system preference was added in the database update script (251200023.pl) but was missing from sysprefs.sql, causing issues for fresh installations that don't run the update script. This preference likely disappeared during rebases. Adding it in the correct alphabetical position between 'timeout' and 'todaysIssuesDefaultSortOrder'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch up-to-date and tidy (In reply to Lucas Gass (lukeg) from comment #17) > /kohadevbox/koha/t/db_dependent/Search.t are also failing for me. Tested again and it works for me. Can you add some details ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #75 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Lol.. friendly fire.. I introduced the new call to GetReserveFee in bug 40769 which was pushed just prior to this one.. It's an easy fix... patches inbound. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 --- Comment #18 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 192902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192902&action=e… Bug 15248: Use record matching rules to find duplicate while cataloging This patch allows to configure how Koha searches for duplicates when cataloging manually by using a record matching rule. For each framework we can now set a record matching rule to use when searching for duplicates. This allow to use different matching rules while in acquisition for instance (ACQ framework). If a matching rule is selected, we also have the ability to forbid the creation of duplicate: if a duplicate is found and this option is enabled, the usual option to create a duplicate will be hidden. If no matching rule is selected, then the default matching mechanism is used. Test plan: 1. Create a record matching rule matching on ISBN Threshold: 100 Record type: biblio Match point: Search index: "isbn" Score: 100 Tag: "020" (or "010" for UNIMARC) Subfields: "a" Offset: 0 Length: 0 Normalization rule: Remove spaces No match checks 2. Edit the default MARC framework and select the new matching rule and enable "Forbid duplicate creation" 3. Create a biblio with an ISBN 4. Make sure your new biblio is indexed in Zebra or ES 5. Try to create a biblio with the same ISBN. You should see a warning about the duplicate with no option to create the duplicate biblio 6. In the acquisitions module, in a basket add a new order from an external source (requires a configured Z39.50/SRU server) 7. Choose a record with an ISBN 8. Once the order is created, try to create a new order from an external source and choose the same record. You should see a warning about the duplicate. 9. Edit the record matching rule and disable "Forbid duplicate creation" 10. Redo step 5. Now there should be an option to create the duplicate record. 11. Redo step 8. Now there should be an option to create the duplicate record. 12. Run the following test scripts: - t/db_dependent/Search.t - t/db_dependent/Matcher.t Sponsored-by: SCD Lyon2 Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> Signed-off-by: Jeanne Maurielle <jeanne.mauriello(a)mainlib.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '26

10 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187134|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0