- Koha-bugs - lists.koha-community.org

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please squash the patches. I am not sure why you change IsAvailableForItemLevelRequest in the third patch. Please explain. Where is it called in the process? You add: + my $flag = shift; This is not really a clear name ;) Where do you use this parameter ? + if (Koha::Holds->search({itemnumber => $item->{itemnumber}, + found => ['W', 'T']}, + {order_by => {-asc => 'priority'}})) { Why do you order_by if you are interested only in the number ? + return 0; + return GetReserveStatus($item->{itemnumber}) eq "Waiting"; When will you reach this second return ? +my $itemsWaitingOrInTransit = Koha::Holds->search( + { + biblionumber => $biblionumber, + found => ['W', 'T'] + })->count(); + +foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) { + $itemsWaitingOrInTransit = 1 if $item->get_transfer; +} If the flag is set, there is no need to start traversing all items or keep doing so. Changing status -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl QA Contact|koha-bugs(a)lists.koha-commun |m.de.rooy(a)rijksmuseum.nl |ity.org | --- Comment #47 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #32 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to M. Tompsett from comment #31) > (In reply to Katrin Fischer from comment #30) > > pply? [(y)es, (n)o, (i)nteractive] y > > Applying: Bug 8630 - Adlibris covers (OPAC minified CSS) > > Using index info to reconstruct a base tree... > > M koha-tmpl/opac-tmpl/bootstrap/css/opac.css > > See my comment #9. This is why I asked Tomas to get lessc into the > kohadevbox. I believe it is there now. > https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files > I'd recommend skipping the first patch, and then rebuilding the minified > OPAC CSS. > I'll try to remember to check back in 12+ hours, and rebase if needed. I didn't make the minified CSS file so I'm not 100% sure what to do with it! Martin can you check in here please? I think it was your patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] results per page setting for catalog search in staff client and opac
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #41 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 68305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68305&action=ed… Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] results per page setting for catalog search in staff client and opac
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #40 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Katrin Fischer from comment #36) > Sequence of attached patches is wrong, but works when you apply them in > order :) Fixed! > I have started testing by regression testing the bibliographic frameworks > export and import and for the default framework some things seem not quite > right: > > - When exporting the default framework to Excel format the file ending > changed from xml to ods for bibliographic frameworks hmm I could not recreate this! it seemed to work fine for me > - Reimporting the exported file for Default always results in unspecific > error message. I believe I have fixed this in latest follow-up patch! > - QA might ask for tests for the changes to ImportExportFramework.pm I had a look for the tests but couldn't find them for some reason - do you know what file they're in? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #39 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 68301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68301&action=ed… Bug 13952: [FOLLOW-UP] Fixing import for default auth type -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64421|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 68300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68300&action=ed… Bug 13952: [FOLLOW-UP] Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '17

20 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67915|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 68299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68299&action=ed… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0