- Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #116 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 68186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68186&action=ed… Bug 7317: Add unit tests & fix, add comments to Illrequest.pm. * Koha/Illrequest.pm: Add code commentary. (_backend_capability): We need to invoke our code ref. * t/db_dependent/Illrequest/Config.t: Improve tests. * t/db_dependent/Illrequestattributes.t: Improve tests. * t/db_dependent/Illrequests.t: Improve tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #115 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 68185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68185&action=ed… Bug 7317: Remove obsolete files. The tests files will be replaced with t/db_dependent/Illrequests.t. Dummy backend files are now in their own repository. * Koha/Illrequest/Backend/Dummy/Base.pm: Delete. * t/db_dependent/Illrequest.t: Delete. * t/db_dependent/Illrequest/Dummy.t: Delete. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #57 from M. Tompsett <mtompset(a)hotmail.com> --- Trying to test acquisition change... having difficulties. I don't think it is a code issue. BTW, Additional fields does look okay for a circulation Z39.50 search. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #56 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 67314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67314 Bug 12747 - Corrections on QA feedback Review of attachment 67314: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: C4/Breeding.pm @@ -224,5 @@ > - @servers = (); > - foreach my $id (@id) { > - push @servers, {id => $id}; > - } > - Why was this removed? Did you add it before? @@ +344,5 @@ > + > + return $row; > +} > + > +sub _add_custom_field_rowdata Nice extraction. ::: installer/data/mysql/sysprefs.sql @@ +9,2 @@ > ('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), > +('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), Intermediate patches dealing with rebases makes this look like a mistake. Squashing is frequently a good idea where possible. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ +133,4 @@ > <th>Author</th> > <th>ISBN</th> > <th>LCCN</th> > + [% IF Koha.Preference('AdditionalFieldsInZ3950ResultSearch') != '' %] Length, != ''... okay, this is better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin(a)inlibro.com |david.bourgault(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #55 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66589 Bug12747 - Small fix for add this field correctly in cataloging module Review of attachment 66589: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- I don't see the point of this patch. If the issue was adding 000, then check length. Less parameters is always better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #54 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66588 Bug12747 - Follow-up to QA Review of attachment 66588: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: t/db_dependent/Breeding.t @@ +195,5 @@ > + > +sub test_add_rowdata { > + > + my $old_preference = C4::Context->preference("AdditionalFieldsInZ3950ResultSearch"); > + C4::Context->set_preference("AdditionalFieldsInZ3950ResultSearch",""); It would be better to mock the preference, so that failure would not affect the database. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66587 Bug 12747 - Add extra column in Z3950 search result Review of attachment 66587: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: C4/Breeding.pm @@ +362,4 @@ > my @addnumberfields; > foreach (@addnumber_array) { > my $length = length($_); > my $adTag = substr($_, 0, 3); If the field is: 100$a 245$a 700$a Then why aren't you: my @fields_to_add = split / /, $pref_addnumber; And inside the the loop: foreach my $field (@fields_to_add) { my ($tag,$subtags) = split |\$|, $field; You are making an assumption that the user won't type something bad like 20$a instead of 020$a. Notice my use of $subtags, because that would be the 'abc' or whatever was set. my @subtags = split //,$subtags; # I believe this splits each character out. foreach my $subtag (@subtags) { substr() calculations are just messy and slow. @@ +385,5 @@ > + my $subfields_text = $field->as_string(); > + push(@addnumberfields, $_); > + $row->{$_} = $subfields_text; > + } > + } And then all this logic could be optimized. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8) > The patch appears to break the list of checkouts in the patron account: > > Error: Syntax error, unrecognized expression: ##issues-table Indeed, I git grepped on **/*.tt but there was an occurrence in a .js file. Thanks for the catch! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68184&action=ed… Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost -- You are receiving this mail because: You are watching all bug changes.

1 0