- Koha-bugs - lists.koha-community.org

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Think we still need a last; statement after this one too: $self->screen_msg("Item is reserved for another patron upon return."); $noerror = 0; But I tested this situation too. Better to exit the loop rightaway now? No blocker, but theoretically one error could be overwritten by another. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- notforloan is OK too -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Tested: OK INVALID_DATE OK due date before now LUKT NIET MET SIP OK $borrower->{'category_type'} eq 'X' => STATS OK DEBARRED OK EXPIRED OK DEBT OK OTHER_CHARGES NOT_FOR_LOAN OK no renewal OK already issued OK reserve waiting === 9300CNmarcel|COsecret|CPRMA| 11NN20170908 10400020170324 144000AOCPL|AA1|ABperl01|ACsecret| transaction date due date 121NNY20170908 103749AORMA|AA1|ABperl01|AJ|AH20170929 235900| old due date still OK? 121YNY20170908 104034AORMA|AA1|ABperl01|AJ|AH20171020 235900|AFItem already checked out to you: renewing item.| 120NUN20170908 104157AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : NO_MORE_RENEWALS|BLY| OBSERVATION: When the checkout fails, SIP returns a VALID_PATRON response BL=Y invalid due date: 11NN20170908 10400020171324 144000AOCPL|AA1|ABperl01|ACsecret| still OK OBSERVATION: The due date passed in the sip request is simply ignored. If I pass an old date or even an invalid date, the item is still checked out. statistical patron 121NNY20170908 105517AORMA|AA1|ABperl01|AJ|AH20170929 235900| Should fail. Bug 19276 opened (error in CanBookBeIssued) debarred 120NUN20170908 112612AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| Sep 8 11:17:21 master koha_sip[14160]: add_field: Undefined value being added to 'AJ' expired 120NUN20170908 112802AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| too much charges (noissuecharge) 120NUN20170908 113317AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| Looks like the check in do_checkout is not even needed. Blocked before calling do_checkout. other charges resulting in DEBT and OTHER_CHARGES alert 120NUN20170908 113609AORMA|AA1|ABperl01|AJ|AH|AFOutstanding Fines block issue|BLY| not for loan 120NUN20170908 114107AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : NOT_FOR_LOAN|BLY| other patron reserve waiting 120NUN20170908 114331AORMA|AA1|ABperl01|AJ|AH|AFItem is on hold shelf for another patron.|BLY| hacking CanBookBeIssued returning BIGERROR in issuingimpossible 120NUN20170908 114606AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : BIGERROR|BLY| hacking CanBookBeIssued returning BIGERROR in needsconfirmation 120NUN20170908 114726AORMA|AA1|ABperl01|AJ|AH|AFItem cannot be issued: BIGERROR|BLY| passing lowercase nonsense in both hashrefs WORKS 121NNY20170908 114834AORMA|AA1|ABperl01|AJ|AH20170929 235900| -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19276 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here again -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #12) > Created attachment 66951 [details] [review] > Bug 15339: Remove extra 'my' O my. Thx for catching that.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18466] New: No article requests breaks the opac-user-views block
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466 Bug ID: 18466 Summary: No article requests breaks the opac-user-views block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Created attachment 62508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62508&action=ed… screenshot If you have no open article requests, the tabbed box with checked out items, article requests. etc. just below the patron's name is awkward looking when you click on the article requests tab: the box below the tabs disappears because the way the `[% IF Koha.Preference('ArticleRequests') && IF borrower.article_requests_current.count %]` condition is written no table is printed at all. Sorry if I'm articulating this poorly, a screenshot is attached. Patch coming shortly, I'm just going to mimic the behavior of the checked out items section when there are no checked out items. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 12346] False patron modification alerts on members-home.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66880|0 |1 is obsolete| | --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 66966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66966&action=ed… Bgu 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable? Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12346] False patron modification alerts on members-home.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0