- Koha-bugs - lists.koha-community.org

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Looks good to me apart from a few minor comments (see above). Just noting: When the checkout fails, SIP returns a VALID_PATRON response BL=Y. It does not when the checkout is ok. The due date passed in the sip request is simply ignored. If I pass an old date or even an invalid date, the item is still checked out. Opened bug 19276 for error in CanBookBeIssued re statistical patrons. We could perhaps use a unit test that helps us 'force' a policy somehow about the lowercase/uppercase returns from CanBookBeIssued. We are still missing a checkout test in t/db/SIP/Message. No time to write it here. In view of the age of this patch and the attention already given by several people before me, I am passing QA on this patch now too. (The last comment of Kyle could be read as a kind of signoff too btw.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 66983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66983&action=ed… Bug 15438: [QA Follow-up] Moving POD statement for CanBookBeIssued The statement for head3 NB ('nota bene'?) looks like a hash key in the list of possible return values for $needsconfirmation. Moved it up and prefixed it with IMPORTANT. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64265|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 66982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66982&action=ed… Bug 15438 - Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field. The returns from C4::Circulation::CanBookBeIssued used to be structured as a hashref of entries like REASON => { data => 'foo', moredata => 'bar', }; Some entries still are. But many are now REASON => 1, data => 'foo', moredata => 'bar', The sip Checkout routine still assumed the former, as it reports any causes it was not aware of (to maintain support for a changing api) The data fields could leak into the screen message field of the response. e.g. the borrowernumber or surname of the borrower who has a hold on an issued title. Some real messages were getting obscured by this This patch sanatizes the return from from CanBookBeIssued by removing keys which are not all uppercase It also fixes a case where the key's data element was used for the screen message when we should use the key itself Updated the documentation of CanBookBeIssued to flag up the assumption re case and the fact that 3 elements rather than two may be returned The loop through the returned keys was a bit bogus so we now explicitly jump out if noerror is unset Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested quite extensively. Test results put on Bugzilla. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Think we still need a last; statement after this one too: $self->screen_msg("Item is reserved for another patron upon return."); $noerror = 0; But I tested this situation too. Better to exit the loop rightaway now? No blocker, but theoretically one error could be overwritten by another. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- notforloan is OK too -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Tested: OK INVALID_DATE OK due date before now LUKT NIET MET SIP OK $borrower->{'category_type'} eq 'X' => STATS OK DEBARRED OK EXPIRED OK DEBT OK OTHER_CHARGES NOT_FOR_LOAN OK no renewal OK already issued OK reserve waiting === 9300CNmarcel|COsecret|CPRMA| 11NN20170908 10400020170324 144000AOCPL|AA1|ABperl01|ACsecret| transaction date due date 121NNY20170908 103749AORMA|AA1|ABperl01|AJ|AH20170929 235900| old due date still OK? 121YNY20170908 104034AORMA|AA1|ABperl01|AJ|AH20171020 235900|AFItem already checked out to you: renewing item.| 120NUN20170908 104157AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : NO_MORE_RENEWALS|BLY| OBSERVATION: When the checkout fails, SIP returns a VALID_PATRON response BL=Y invalid due date: 11NN20170908 10400020171324 144000AOCPL|AA1|ABperl01|ACsecret| still OK OBSERVATION: The due date passed in the sip request is simply ignored. If I pass an old date or even an invalid date, the item is still checked out. statistical patron 121NNY20170908 105517AORMA|AA1|ABperl01|AJ|AH20170929 235900| Should fail. Bug 19276 opened (error in CanBookBeIssued) debarred 120NUN20170908 112612AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| Sep 8 11:17:21 master koha_sip[14160]: add_field: Undefined value being added to 'AJ' expired 120NUN20170908 112802AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| too much charges (noissuecharge) 120NUN20170908 113317AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| Looks like the check in do_checkout is not even needed. Blocked before calling do_checkout. other charges resulting in DEBT and OTHER_CHARGES alert 120NUN20170908 113609AORMA|AA1|ABperl01|AJ|AH|AFOutstanding Fines block issue|BLY| not for loan 120NUN20170908 114107AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : NOT_FOR_LOAN|BLY| other patron reserve waiting 120NUN20170908 114331AORMA|AA1|ABperl01|AJ|AH|AFItem is on hold shelf for another patron.|BLY| hacking CanBookBeIssued returning BIGERROR in issuingimpossible 120NUN20170908 114606AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : BIGERROR|BLY| hacking CanBookBeIssued returning BIGERROR in needsconfirmation 120NUN20170908 114726AORMA|AA1|ABperl01|AJ|AH|AFItem cannot be issued: BIGERROR|BLY| passing lowercase nonsense in both hashrefs WORKS 121NNY20170908 114834AORMA|AA1|ABperl01|AJ|AH20170929 235900| -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19276 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '17

08 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here again -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #12) > Created attachment 66951 [details] [review] > Bug 15339: Remove extra 'my' O my. Thx for catching that.. -- You are receiving this mail because: You are watching all bug changes.

1 0