- Koha-bugs - lists.koha-community.org

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Thx for your proposal. Some points that need attention: Breeding.pm: @servers = (); foreach my $id (@id) { push @servers, {id => $id}; } Please explain what you are doing here. Seems unneeded or wrong. $template->param( additionalFields => '1' ) if C4::Context->preference('AdditionalFieldsInZ3950ResultSearch'); Please use Koha::Preference in the template. sub _add_rowdata Just intuitive, these additions dont look that nice to me. I think you should add more validation and put this in another subroutine, taking care that you do not overwrite the default fields. +++ b/installer/data/mysql/atomicupdate/bug_12747-additional_fields_in_Z3950_search_result.sql @@ -0,0 +1 @@ +INSERT INTO systempreferences Please INSERT IGNORE +('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), Please respect the sort order in sysprefs. Note: I saw that a LOT of other new prefs are not in the right order. But you dont need to correct that here of course. Just add your own one in the right place. + [% IF additionalFields %] + <td> + <dl> + [% FOREACH addnumberfield IN breeding_loo.addnumberfields %] + <dt>[% addnumberfield %]:</dt> + <dd>[% breeding_loo.$addnumberfield %]</dd> + [% END %] + </dl> + </td> + [% END %] You add all additional fields in one column?? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library' s circ rules
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jesse Weaver <pianohacker(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pianohacker(a)gmail.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library' s circ rules
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #1 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 66681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66681&action=ed… Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19232] New: Move C4::CourseReserves code into Koha:: CourseReserve modules
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19232 Bug ID: 19232 Summary: Move C4::CourseReserves code into Koha::CourseReserve modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- It works for me, please try again, you must be logged with a non-superlibrarian users and have editcatalogue => edit_items_restricted -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19226] New: Show card number changes in logs
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '17

31 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19226 Bug ID: 19226 Summary: Show card number changes in logs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Would like the MODIFY action in the logs to specifically show card number changes. Like "Card changed from XXXXXXX to YYYYYYY." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2