- Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65325|0 |1 is obsolete| | --- Comment #48 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65387&action=ed… Bug 14385: Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65324|0 |1 is obsolete| | --- Comment #47 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65386&action=ed… Bug 14385: Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65323|0 |1 is obsolete| | --- Comment #46 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65385&action=ed… Bug 14385: Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65322|0 |1 is obsolete| | --- Comment #45 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65384&action=ed… Bug 14385: Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64693|0 |1 is obsolete| | --- Comment #44 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65383&action=ed… Bug 14385: Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64692|0 |1 is obsolete| | --- Comment #43 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65382&action=ed… Bug 14385: Always use mocks, not set_preference Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64691|0 |1 is obsolete| | --- Comment #42 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65381&action=ed… Bug 14385: Added missing GetHiddenItems parameter change case Without this prove t had a failure. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64690|0 |1 is obsolete| | --- Comment #41 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65380&action=ed… Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64689|0 |1 is obsolete| | --- Comment #40 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65379&action=ed… Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64688|0 |1 is obsolete| | --- Comment #39 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65378&action=ed… Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0