- Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #125 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Thanks Julian -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #124 from Julian Maurice <julian.maurice(a)biblibre.com> --- koha-qa is happy, prove is happy, and I couldn't find any issue during my tests, so I'm happy too :) Passed QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62055|0 |1 is obsolete| | --- Comment #123 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62137&action=ed… Bug 9988: [QA Follow-up] Satisfy QA issues [1] See comment102. Moved sub reporting_tag_xml to MergeRequest.pm. Adjusted t/db_dependent/Koha/Authorities.t accordingly. This resolves the C3 inconsistent hierarchy errors. [2] Removed empty POD section Instance Methods from MergeRequests. This resolves the POD error in comment102 point 2. [3] Include a tag 100 for UNIMARC in reporting_tag_xml to resolve an error on encoding in MARC::File::XML. Subtest for oldmarc and subtest for reporting_tag_xml adjusted accordingly. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61925|0 |1 is obsolete| | --- Comment #122 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62136&action=ed… Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61924|0 |1 is obsolete| | --- Comment #121 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62135&action=ed… Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61923|0 |1 is obsolete| | --- Comment #120 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62134&action=ed… Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61922|0 |1 is obsolete| | --- Comment #119 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62133&action=ed… Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61921|0 |1 is obsolete| | --- Comment #118 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62132&action=ed… Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61920|0 |1 is obsolete| | --- Comment #117 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62131&action=ed… Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61919|0 |1 is obsolete| | --- Comment #116 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62130&action=ed… Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0