- Koha-bugs - lists.koha-community.org

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61565&action=ed… Bug 13757: (QA followup) Check DB structure before altering table Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61564&action=ed… Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #115 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61563&action=ed… Bug 13757: (followup) Regression tests for ->approve changes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #114 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61562&action=ed… Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #113 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61561&action=ed… Bug 13757: (followup) Staff interface changes This patch adds proper extended attributes display and handling on the patron modifications moderation page (members-update.pl). It also adds changes checking to the opac-memberentry.pl page so it only saves a modification request if there are changes (it only checked regular fields and not the extended ones). Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #112 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61560&action=ed… Bug 13757: (followup) Remove warnings Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #111 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61559&action=ed… Bug 13757: Add extended attributes to the patron modification Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #110 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61558&action=ed… Bug 13757: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #109 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61557&action=ed… Bug 13757: OPAC changes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #108 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61556&action=ed… Bug 13757: DB update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0