- Koha-bugs - lists.koha-community.org

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #100 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61148&action=ed… Bug 13757: Better display for attr changes in members-update.pl This patch changes the way changed attributes are displayed for the staff user to make the decision to approve (or not) the changes. Regards Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #99 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61147&action=ed… Bug 13757: Make K::P::Modifications->pending return K::P::Attribute This patch makes Koha::Patron::Modifications->pending return Koha::Patron:Attribute objects. They are not stored on the DB but only live in memory on runtime. members-update.pl is the only place this is used, and this way we have all we need for better rendering the UI. Tests are added for the changed API. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #98 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61146&action=ed… Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #97 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61145&action=ed… Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #96 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61144&action=ed… Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #95 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61143&action=ed… Bug 13757: (regression tests) Empty attributes should delete existing This patch introduces tests for the required functionality. To test: - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: The current code doesn't work like that Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #94 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61142&action=ed… Bug 13757: (QA followup) Check DB structure before altering table Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #93 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61141&action=ed… Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #92 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61140&action=ed… Bug 13757: (followup) Regression tests for ->approve changes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #91 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61139&action=ed… Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0