- Koha-bugs - lists.koha-community.org

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #70 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Rebased to master. (In reply to Jonathan Druart from comment #65) > Can you explain this patch? Yes. Without this bad things will happen when caching is used. Our page load times drop at best 2-4 seconds depending on the env we run Koha. Better than plack :) When the Koha-version changes, the urls for all static web-assets dynamically change to point at the new Koha-version. This forces the browser to reload new versions of javascript-code. You cannot really cache static web-content without a way of invalidating the user's cache, because then after version upgrades, some browsers would use old javascript code and bad things would happen. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #69 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Created attachment 60831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60831&action=ed… Bug 12904 - Add mod_expire to etc/koha-httpd.conf Has a positive effect on page loads for crazy dev-installs as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58395|0 |1 is obsolete| | --- Comment #68 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Created attachment 60830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60830&action=ed… Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58394|0 |1 is obsolete| | --- Comment #67 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Created attachment 60827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60827&action=ed… Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58393|0 |1 is obsolete| | --- Comment #66 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Created attachment 60826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60826&action=ed… Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60824|0 |1 is obsolete| | --- Comment #48 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 60825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60825&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #47 from David Gustafsson <glasklas(a)gmail.com> --- Nope, still managed to screw it up. Should be ok now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #46 from David Gustafsson <glasklas(a)gmail.com> --- Screwed up the last merge. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60711|0 |1 is obsolete| | --- Comment #45 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 60824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60824&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13913] Renewal error message in OPAC is confusing
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '17

06 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Renewal error message in |Renewal error message in |OPAC is not correct |OPAC is confusing --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We have another report on this. Currently, all reasons why a renewal failed are listed as unformatted text and it's very hard to see, which message applies to which checkout. We shoudl fix this to show the specific reasons with the issues and only a general message on top. -- You are receiving this mail because: You are watching all bug changes.

1 0