- Koha-bugs - lists.koha-community.org

[Bug 14166] exportable version of reading history
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14166 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #47 from Lari Taskula <lari.taskula(a)jns.fi> --- (In reply to Josef Moravec from comment #43) > Test t/db_dependent/api/v1/accountlines.t fails: > > Use of uninitialized value $amount in subtraction (-) at > /home/vagrant/kohaclone/Koha/Account.pm line 178. > Use of uninitialized value $amount in subtraction (-) at > /home/vagrant/kohaclone/Koha/Account.pm line 205. > > # Failed test at t/db_dependent/api/v1/accountlines.t line 178. > # Looks like you failed 1 test of 37. > > > it's because the Koha::Account->pay always need an amount... so when api > doesn't get an amount parameter, it can't have anything to pass - I think > the API should return an error then I took a look at this and provided a patch to fix it. Initially I wanted to enhance Koha::Account->pay to throw Koha::Exceptions in case of invalid input for amount (non-numeric / not given / not more than zero) but I guess it could cause problems elsewhere and is probably out of this bug's scope. Swagger offers the tools to fix this nicely ("required" parameter and "minimum"/"exclusiveMinimum" to define min amount). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59933|0 |1 is obsolete| | --- Comment #46 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 59934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59934&action=ed… Bug 15165: Set amount parameter required, define its data type and confirm amount > 0 This patch enforces "amount" to be required when paying towards accountline(s). It also specifies the data type of amount, so that nonsense amounts like "strings" cannot go through. Also, defines minimum amount as 0 and exclusiveMinimum true so that the amount must be greater than 0 (and not equal). This patch also wraps the operations in try/catch as now recommended. Possible enhancements to Koha::Account->pay could also be done so that we would catch Koha::Exceptions in the case of invalid input. However, this is probably outside the scope of this bug and would require more testing on other components as well. After all, we can handle the input nicely with Swagger alone. To test: 1. prove t/db_dependent/api/v1/accountlines.t 2. prove t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #45 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 59933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59933&action=ed… Bug 15165: Set amount parameter required, define its data type and confirm amount > 0 This patch enforces "amount" to be required when paying towards accountline(s). It also specifies the data type of amount, so that nonsense amounts like "strings" cannot go through. Also, defines minimum amount as 0 and exclusiveMinimum true so that the amount must be greater than 0 (and not equal). This patch also wraps the operations in try/catch as now recommended. Possible enhancements to Koha::Account->pay could also be done so that we would catch Koha::Exceptions in the case of invalid input. However, this is probably outside the scope of this bug and would require more testing on other components as well. After all, we can handle the input nicely with Swagger alone. To test: 1. prove t/db_dependent/api/v1/accountlines.t 2. prove t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #44 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 59932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59932&action=ed… Bug 15165: Remove meansofpayment parameter Accountlines does not have such column in current master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14535] Late orders does not show orders with price = 0
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59922|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 59928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59928&action=ed… Bug 14535: Update the supplier filter too The combobox on the left side of late orders is filled by sub GetBooksellersWithLateOrders. The same change as in the first patch must be made here to include suppliers with late orders without a price. Bonus: Sort the list. Test plan: [1] Run t/db_dependent/Bookseller.t. [2] Go to late orders. Use the filter on suppliers. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14535] Late orders does not show orders with price = 0
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14535] Late orders does not show orders with price = 0
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 59922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59922&action=ed… Bug 14535: Update the supplier filter too The combobox on the left side of late orders is filled by sub GetBooksellersWithLateOrders. The same change as in the first patch must be made here to include suppliers with late orders without a price. Test plan: [1] Run t/db_dependent/Bookseller.t. [2] Go to late orders. Use the filter on suppliers. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14535] Late orders does not show orders with price = 0
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '17

06 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Still need another change -- You are receiving this mail because: You are watching all bug changes.

1 0