- Koha-bugs - lists.koha-community.org

[Bug 13169] C4::Templates::themelanguage fails if the DB is not populated
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 [Bug 17982] Fix the use of uniq in sub themelanguage -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #67 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Josef Moravec from comment #66) > (In reply to Jonathan Druart from comment #55) > > Created attachment 59780 [details] [review] [review] > > Bug 14224: Check if the columns do not exist before creating them > > > > Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> > > Probably better to ommit "IGNORE" when using column_exists function, what do > you think? But it's only think, otherwise everything looks good -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #66 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Jonathan Druart from comment #55) > Created attachment 59780 [details] [review] > Bug 14224: Check if the columns do not exist before creating them > > Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Probably better to ommit "IGNORE" when using column_exists function, what do you think? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #65 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- And 2 more. I do not really care about the number of patches, someone can squashed them. I think that makes the changes more readable and separate the different problems. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59788&action=ed… Bug 14224: Improve escaped characters To recreate the problem, submit a note like doh"doh Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #63 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59787&action=ed… Bug 14224: Update Copyright Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I'd like either a signoff on these follow-ups or someone else to QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #61 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59786&action=ed… Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #60 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59785&action=ed… Bug 14224: Make strings translatable The strings should be translatable. This patch also removes the error as it appears that we only have 1 error. To improve we could surround the store with an eval. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #59 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59784&action=ed… Bug 14224: Fix prevent submit That did not work, the form was submitted anyway Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0