- Koha-bugs - lists.koha-community.org

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #49 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #41) > If I enter a wrong format into the year field, it says 'Please use the specified > format' (translated from German), but gives no clue about the format. On the 2nd thought, previous pattern ("[12][0-9\-\?]{3}") wasn't making much sense - copyrightdate in the DB is just smallint(5). Added a hint for the user regarding the required format for that field as a title="", i.e. tooltip. Doesn't always work quite perfectly (depending on the browser), but hopefully it would be good enough for the time being / close enough for government work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17115] New: Reserves.t fails
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17115 Bug ID: 17115 Summary: Reserves.t fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: gmcharlt(a)gmail.com t/db_dependent/Reserves.t .. 2/74 SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator 'cancellationdate' with undef operand at Koha/Objects.pm line 168 To investigate, may be a major one. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #48 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54356&action=ed… Bug 10848 - [QA Followup] Add missing branch option and fix pattern for copyrightdate - HTML5 input pattern for copyrightdate was not taking into an account the database field type, which is smallint(5) - added title="..." for the year field so the acceptable date format should be displayed as a hint/tooltip in the browser - added an missing option for configuring branch/library as mandatory -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17115 --- Comment #66 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #65) > Another thing :) > > perl t/db_dependent/Reserves.t > 1..74 > ok 1 - use C4::Reserves; > Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line > 45. > ok 2 - CheckReserves Test 1 > ok 3 - CheckReserves() include reserve_id in its response > ok 4 - CheckReserves Test 2 > ok 5 - CheckReserves Test 3 > ok 6 - GetReservesControlBranch returns item home branch when set to > ItemHomeLibrary > ok 7 - GetReservesControlBranch returns patron home branch when set to > PatronLibrary > DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected > operator 'cancellationdate' with undef operand at > /usr/share/koha/masterclone/Koha/Objects.pm line 168 > # Looks like you planned 74 tests but ran 7. > # Looks like your test exited with 255 just after 7. Exsts on master, see bug 17115. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #65 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Another thing :) perl t/db_dependent/Reserves.t 1..74 ok 1 - use C4::Reserves; Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line 45. ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected operator 'cancellationdate' with undef operand at /usr/share/koha/masterclone/Koha/Objects.pm line 168 # Looks like you planned 74 tests but ran 7. # Looks like your test exited with 255 just after 7. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54355&action=ed… Bug 15407: (follow-up) Koha::Patron::Categories - replace C4::Category->al Categories.GetName should not have been removed in the previous patch (merge conflict issue). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #63 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please git grep on Categories.GetName Koha/Template/Plugin/Categories.pm:[% Categories.GetName( categorycode ) %]. koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc: koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt: Remove the pod and replace the three remaining calls please.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #62 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54353&action=ed… Bug 15407: [QA Follow-up] Joubu, add your tests Trivial fix (yes again). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #61 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- - my %cathash = ($line eq 'categorycode' or $column eq 'categorycode') ? &catcodes_hash : (); - push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map {$cathash{$_}} sort keys %cathash)}; + my $patron_categories = Koha::Patron::Categories->search({}, {order_by => ['categorycode']}); + push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map { $_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')'} $patron_categories->as_list )}; You removed cathash, but left it in the push -- You are receiving this mail because: You are watching all bug changes.

1 0