October 2007 - Koha-bugs - lists.koha-community.org

[Bug 1477] moremember.pl doesn't display holds
by bugzilla-daemon＠pippin.metavore.com 22 Oct '07

22 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1477 ------- Comment #4 from joe.atzberger(a)liblime.com 2007-10-22 10:17 ------- In 1506, Josh, you said "This is an example perhaps of writing a bit of clever perl code, perhaps looks cleaner than defining a separate variable, and using it instead of the default scalar." I'm not sure what you meant to say, but I think it is something about not trying to be too clever? As for checks, this script doesn't set the values. It pulls them from GetMember, so sanity checks on the DB should probably go there. Right now it looks like memberentrygen.tmpl has failed merge in the git repo, so my testing is blocked a bit. I'm working on members.js to make the validation functions compatibly format-agnostic. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1402] Renew link on patron detail screen does nothing
by bugzilla-daemon＠pippin.metavore.com 22 Oct '07

22 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1402 oleonard(a)myacpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major ------- Comment #1 from oleonard(a)myacpl.org 2007-10-22 06:58 ------- Now I get an error: failed C4::Dates->new(, 'iso')->output() at /intranet/cgi-bin/members/moremember.pl line 95. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1508] Expiration date not saved with news items
by bugzilla-daemon＠pippin.metavore.com 22 Oct '07

22 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1508 ------- Comment #1 from jmf(a)liblime.com 2007-10-22 05:52 ------- rank isn't saved either ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1504] Additem Fails
by bugzilla-daemon＠pippin.metavore.com 22 Oct '07

22 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1504 ------- Comment #1 from jmf(a)liblime.com 2007-10-21 19:53 ------- This is much improved, saving most items field works now. There is still a problem with subfield 0 (zero). If you have subfield zero defined and mapped, it doesn't save properly. Also, although some of the fields at the item-level can be defined as repeatable, I'm not sure what the utility of these are, since they map to a single table, and so can't really be repeated. I'm also a bit skeptical as to whether the items table is being treated as authoritative for all edits/adds ... if the MARC changed, would what exists in items be preserved? If items changed, would it do the right thing and overwrite what is in the MARC? I will attempt to do some tests to find out. Just to clarify, the only reason the data is stored in the MARC in the first place is so we can search on it, the MARC isnt' intended to be an authoritative place to store items data. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1509] New: List of Toolbar Issues
by bugzilla-daemon＠pippin.metavore.com 22 Oct '07

22 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1509 Summary: List of Toolbar Issues Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: blocker Priority: P3 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: jmf(a)liblime.com QAContact: koha-bugs(a)nongnu.org circulation.pl: print page, print slip don't do anything :-) delete fails: confirm_deletion is not defined renew account fails: confirm_reregistration is not defined add note doesn't exist Some of the pages that circulation links too don't have the toolbar defined in the same way (permissions, change password, etc.). Maybe the circ toolbar include should be standard across all circulation pages detail.pl Add to Shelf doesn't do anything print doesnt' work Place hold fails ... this might need to be filed as a separate bug as it caused the perl file to be downloaded. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1508] New: Expiration date not saved with news items
by bugzilla-daemon＠pippin.metavore.com 21 Oct '07

21 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1508 Summary: Expiration date not saved with news items Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Parameters AssignedTo: paul.poulain(a)free.fr ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)nongnu.org Expiration date is not saved when a news item is added or when it is edited. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1506] moremember.pl failing, new Dates method
by bugzilla-daemon＠pippin.metavore.com 21 Oct '07

21 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1506 jmf(a)liblime.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE ------- Comment #1 from jmf(a)liblime.com 2007-10-20 18:52 ------- *** This bug has been marked as a duplicate of bug 1477 *** ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1477] moremember.pl doesn't display holds
by bugzilla-daemon＠pippin.metavore.com 21 Oct '07

21 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1477 ------- Comment #3 from jmf(a)liblime.com 2007-10-20 18:52 ------- *** Bug 1506 has been marked as a duplicate of this bug. *** ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1507] New: Possible Missing Foreign Key in Accountoffsets
by bugzilla-daemon＠pippin.metavore.com 21 Oct '07

21 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1507 Summary: Possible Missing Foreign Key in Accountoffsets Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Database AssignedTo: paul.poulain(a)free.fr ReportedBy: cnighswonger(a)foundations.edu QAContact: koha-bugs(a)nongnu.org Paul, Looks like accountoffsets.borrowernumber might be missing a foreign key reference to borrowers.borrowernumber This is an assumption based on the fk in accountlines. Sorry if its incorrect. tnx. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 1506] New: moremember.pl failing, new Dates method
by bugzilla-daemon＠pippin.metavore.com 21 Oct '07

21 Oct '07

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1506 Summary: moremember.pl failing, new Dates method Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: blocker Priority: P3 Component: Members AssignedTo: joe.atzberger(a)liblime.com ReportedBy: jmf(a)liblime.com QAContact: koha-bugs(a)nongnu.org Add or edit a member, click save, it redirects you to moremember.pl, which fails due to the following block: foreach (qw(dateenrolled dateexpiry dateofbirth)) { $data->{$_} = C4::Dates->new($data->{$_}, 'iso')->output() or die ("failed C4::Dates->new(" . $data->{$_} . ", 'iso')->output()"); } First, I don't think we want it to 'die' ... that's a bit to harsh I think. Second, we assume that dateenrolled, dateexpiry and dateofbirth are all valid. Third, the $data->{$_} is given a null value if there's not a value, so when there's a problem it won't tell you which of the values it's failing on. This is an example perhaps of writing a bit of clever perl code, perhaps looks cleaner than defining a separate variable, and using it instead of the default scalar. Should also check to make sure that the dates are coming out as iso in the right format that Dates expects ... I've marked it as blocker since it prevents moremember from working ;-) ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0