June 2012 - Koha-bugs - lists.koha-community.org

[Bug 8116] New: z3950 empty search causes silent warning in koha-error_log
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '12

05 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8116 Priority: P5 - low Change sponsored?: --- Bug ID: 8116 Assignee: gmcharlt(a)gmail.com Summary: z3950 empty search causes silent warning in koha-error_log Severity: normal Classification: Unclassified OS: All Reporter: kolpen(a)o2.pl Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Created attachment 9633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9633&action=edit proposed patch When searching z3950 with empty parameter list a silent warning occurs in koha-error_log: z3950_search.pl: Use of uninitialized value in subroutine entry at /usr/lib/perl5/ZOOM.pm line 491 The reason is unassigned value in variable $query in line 118 of z3950_search.pl module. The bug occurs also in earlier Koha version (3.6) -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 8111] New: Language chooser display problem in self-checkout
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '12

05 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111 Priority: P5 - low Change sponsored?: --- Bug ID: 8111 Assignee: oleonard(a)myacpl.org Summary: Language chooser display problem in self-checkout Severity: normal Classification: Unclassified OS: All Reporter: oleonard(a)myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Self checkout Product: Koha The self-checkout page lacks the proper JS includes to generate the language-chooser menu when there are multiple variants of a language. The SCO-specific CSS file also lacks some updates which were made to the main CSS for this feature. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 7599] New: Cart JavaScript contains untranslatable English strings
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '12

05 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Bug #: 7599 Summary: Cart JavaScript contains untranslatable English strings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: koha.sekjal(a)gmail.com CC: gmcharlt(a)gmail.com In the OPAC and staff client cart JavaScript: function updateBasket(updated_value,target) { if(target){ target.$('#basketcount').html(" <span>("+updated_value+")</span>"); target.$('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); } else { $('#basketcount').html(" <span>("+updated_value+")</span>"); $('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); } var basketcount = updated_value; } Not only is this untranslatable, the structure of the sentence is probably too English-centric. Perhaps, "Items in your cart: " + count ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 7

[Bug 8129] New: quick slips issuing does not work
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '12

05 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Priority: P5 - low Change sponsored?: --- Bug ID: 8129 CC: gmcharlt(a)gmail.com Assignee: kyle.m.hall(a)gmail.com Summary: quick slips issuing does not work Severity: normal Classification: Unclassified OS: All Reporter: leonardobareno(a)gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha in ./C4/Members.pm, IssueSlip function, $today string has "yyyy-mm-dd" format, but $it->{'issuedate'} and $it->{'due_date'} are in "yyyy-mm-ddThh:mm:ss" format, so the "eq" and "le" string comparisons made later are not going to work. suggested edition in ./C4/Members.pm: if ((substr $it->{'issuedate'}, 0, 10) eq $today) { $it->{'today'} = 1; } elsif ((substr $it->{'date_due'}, 0, 10) le $today) { $it->{'overdue'} = 1; } $it->{'date_due'}=format_date($it->{'date_due'}); } please accept my apologies for my lack of bugEtiquette. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 3638] Status of hold not changed when item checked in via SIP2 Interface
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '12

05 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain(a)biblibre.com Version|master |rel_3_8 --- Comment #18 from Paul Poulain <paul.poulain(a)biblibre.com> --- QA comment: I couldn't test the patch with a true selfcheck machine, but patch pushed. Colin, before the patch there was some perlcritic problems, they are still here after the patch. If you can submit a follow-up to fix them, that would be nice. Should be very easy (removal or "return undef" in favour of "return" and removing prototyping of subs) 16:11 ~/koha.dev/koha-community (new/bug_3638 $%)$ perlcritic C4/SIP/ILS/Item.pm C4/SIP/ILS/Transaction/Checkin.pm C4/SIP/Sip/MsgType.pm C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 89, column 3. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 350, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 352, column 26. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 353, column 51. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 356, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 359, column 28. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 360, column 28. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 361, column 61. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 364, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 366, column 25. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 368, column 24. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Transaction/Checkin.pm source OK C4/SIP/Sip/MsgType.pm: "return" statement with explicit "undef" at line 408, column 3. See page 199 of PBP. (Severity: 5) C4/SIP/Sip/MsgType.pm: Subroutine prototypes used at line 797, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/Sip/MsgType.pm: "return" statement with explicit "undef" at line 798, column 24. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 1918] Minify JavaScript and CSS
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '12

05 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9112|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 9917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9917&action=edit Bug 1918 - Minify JavaScript and CSS Rebased patch. I test for curiosity :) For testing, install libjavascript-minifier-xs-perl and libcss-minifier-xs-perl. You need to create a koha-tmpl/intranet-tmpl/prog/en/combined directory with write mode for www-data Feedback: With firebug, I see 2 errors on the intranet detail page: GET menu-button-arrow.png 404 Not Found GET sprite.png 404 Not Found detail.pl: 21 requests 165.2 KB (159 KB from cache) 2.41s (onload: 2.5s) vs 9 requests 158.9 KB (146.2 KB from cache) 2.66s (121.8 KB JS + 24.3 KB CSS) search.pl (results): 20 requests 167.8 KB (159 KB from cache) 1.6s (onload: 3.68s) vs 4 requests 158.2 KB (146.2 KB from cache) 4.04s (onload: 4.05s) (121.8 KB JS + 24.3 KB CSS) We observe a decrease of the number of requests and data size, but also a small increase of the load time. I don't know if you have checked the load time. I did not test with Plack ! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3638] Status of hold not changed when item checked in via SIP2 Interface
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '12

04 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Ian Walls <koha.sekjal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 Status|Signed Off |Passed QA --- Comment #17 from Ian Walls <koha.sekjal(a)gmail.com> --- First patch: modifies some subroutines in SIP/ILS/Item.pm to take borrowernumber/branchcode params, and set them for the hold. Moves hold handling to do_checkin instead of handle_checkin, and adds the processing from C4::Reserves we'd normally get in the staff client. Also strips out some commented lines. Marking as Passed QA. Second patch: Better handling of conditional (separate lines and shift instead of a Perl one-liner). Adds return_date to do_checkin call. Adds a call to ModItemTransfer where applicable. Bulk of work is to set a default current location, as the self check machine may not. Also marked Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3638] Status of hold not changed when item checked in via SIP2 Interface
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '12

02 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Thanks for the test script example Colin, was very handy for testing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3638] Status of hold not changed when item checked in via SIP2 Interface
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '12

02 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5424|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 9902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9902&action=edit Bug 3638 : Captured Holds may need to generate a transfer If a discharged item is captured for a hold at another branch the selfcheck should generate a branchtransfer for it. This was complicated as the checkin routine was setting its own location from a field not set in many scm machines (e.g. 3M) also in ILS::Transaction the test for location was incorrect assuming that an empty string or undefined was a valid location Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3638] Status of hold not changed when item checked in via SIP2 Interface
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '12

02 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5423|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 9901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9901&action=edit Bug 3638 Self Check Should Capture Hold Items Shelf Check was receiving messages saying item was wanted for a hold but the item was discharged to the shelf not associated with the hold or transited to the pickup location. The message was also being sent on discharge of items when a suitable item had already been captured. Checkin now associates the item with the hold and sets the appropriate data for a correct checkin response Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0