June 2012 - Koha-bugs - lists.koha-community.org

[Bug 7058] New: GetMemberDetails must die!
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '14

25 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 Bug #: 7058 Summary: GetMemberDetails must die! Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: ian.walls(a)bywatersolutions.com ReportedBy: ian.walls(a)bywatersolutions.com QAContact: koha-bugs(a)lists.koha-community.org The GetMemberDetails subroutine is insanely inefficient, and is used throughout Koha's code. In many cases, GetMember is more than sufficient (please see my rant on bug 5179). This report shall serve as the meta-report for all attempts to eliminate unnecessary calls get GetMemberDetails. Please file separate bug reports for specific instances, and list them as "blocking" this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 5

[Bug 5179] New: GetMember and GetMemberDetails should be combined
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '14

25 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5179 Summary: GetMember and GetMemberDetails should be combined Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt(a)gmail.com ReportedBy: robin(a)catalyst.net.nz QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 In Members.pm, GetMember and GetMemberDetails do almost the same thing. This common behaviour should be combined so that changes to this kind of thing don't have to happen in multiple places. Aiming for 3.4. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 2

[Bug 7572] New: Add Clubs & Services Feature
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '14

23 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Bug #: 7572 Summary: Add Clubs & Services Feature Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons AssignedTo: kyle.m.hall(a)gmail.com ReportedBy: kyle.m.hall(a)gmail.com QAContact: koha.sekjal(a)gmail.com CC: gmcharlt(a)gmail.com Add the clubs and services feature to Koha. This feature has been in production at the Crawford County Federated Library system for a number of years now. This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 58

[Bug 6617] New: table of contents not printing right if entered right
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '14

22 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Bug #: 6617 Summary: table of contents not printing right if entered right Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Created attachment 4682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4682 table of contents in 505$a If you're entering the table of contents in a series of $t and $r subfields (in the 505) then it doesn't print the table of contents to the OPAC or staff client right. A formatted table of contents looks like this (505$a): What is a mashup? / Darlene Fichter -- Behind the scenes : some technical details on mashups / Bonaria Biancu -- Making your data available to be mashed up / Ross Singer -- Mashing up with librarian knowledge / Thomas Brevik A slash after the title and before the author and a double dash in between the chapters. See the screenshots to see what I mean. The / should probably be entered by the cataloger, but the double dash should be entered by the template and the contents should show with XSLT turned on even if it's not in the $a only. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 48

[Bug 6918] New: can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '14

19 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Bug #: 6918 Summary: can't place holds on 'on order' items with AllowOnShelfHolds off Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Circulation AssignedTo: kyle.m.hall(a)gmail.com ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org CC: gmcharlt(a)gmail.com I don't think this was always the case (but I might be wrong). If AllowOnShelfHolds is set to 'don't allow' then patrons cannot place holds on items that are marked 'on order' (not for loan=-1). Technically items on order are not on the shelf and should be allowed to be placed on hold. This may require a preference for people to say whether they want to allow holds on 'on order' items and/or what the not for loan value is for 'on order' since there is nothing stopping the user from changing the value from -1 to something else. The easy fix is just to make the system allow holds on items with -1 for notforloan like I think it was before. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 29

[Bug 6374] New: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '14

19 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Bug #: 6374 Summary: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: januszop(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org In many places the name "size" is used as hash key when the hash is passed to the template system for display. So, for example, since "size" is used as a name of a column of bibioitems table, it appears (or not, depending on if it was defined or not) in elements of SEARCH_RESULTS (in catalogue/search.pl or opac-search.pl) and is passed to the template results.tt/opac-results.tt. Then, in [opac-]results.tt a test is being done: [% IF ( SEARCH_RESULT.size ) %] Now: if "size" was defined, everything is OK and the size will be displayed (e.g. 21 cm), BUT if it was not defined, then a "random" number appears. This is because "size" is one of the virtual methods defined in Template::Toolkit for every data type (cf. http://search.cpan.org/~abw/Template-Toolkit-2.22/lib/Template/Manual/VMeth…) So, if "size" was defined by Koha, it will overload the method, but if it was not, then 1) XXX.size exists anyway, 2) the virtual method size() is called -- and it returns the number of elements in the hash or loop etc., depending on what is referred. The number of suspicious similar spots is ca. 20: git grep "IF.*\.size" called in koha-tmpl The issue does not seem to me to be straightforward to resolve, so I am not proposing any patch at the time. Since it seems that in most of the cases it rooted in biblioitems.size column, maybe it would be the simplest to rename that column to 'format' (and make appropriate changes in the code)? Any other ideas? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 27

[Bug 7386] New: Label batches cannot be batch deleted
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Bug #: 7386 Summary: Label batches cannot be batch deleted Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing AssignedTo: cnighswonger(a)foundations.edu ReportedBy: nflanagan(a)maine.rr.com QAContact: ian.walls(a)bywatersolutions.com Currently label batches must be deleted individually. Selecting several batches and clicking the delete button gives the error: "Please select only one batch todelete." It would be a nice enhancement to be able to delete multiple batches at once. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 7

[Bug 8168] New: ersatz CSV header in attachment of overdue notices sent to administrator
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '14

13 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 Priority: P5 - low Change sponsored?: --- Bug ID: 8168 Assignee: henridamien(a)koha-fr.org Summary: ersatz CSV header in attachment of overdue notices sent to administrator Severity: minor Classification: Unclassified OS: All Reporter: gmcharlt(a)gmail.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha overdue_notices.pl sends an email to the Koha admin with any notices that should be printed as an attachment. However, if the attachment contains printable notices, rather than CSV, the first line of the attachment still includes a CSV header: title;name;surname;address1;address2;zipcode;city;email;itemcount;itemsinfo;due_date;issue_date There are two problems with this: [1] This header shouldn't be included unless CSV output was specifically requested (by use of the -csv) switch. [2] The header does not respect the delimiter and tabulation system preferences -- it always uses a semicolon. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 6070] New: On a new order defined from suggestion some fields were missing.
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '14

05 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Bug #: 6070 Summary: On a new order defined from suggestion some fields were missing. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: paul.poulain(a)biblibre.com QAContact: koha-bugs(a)lists.koha-community.org (MT #4937) The missing fields : publicationyear, place, collectiontitle. More the layout has been modified. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 54

[Bug 7934] New: Separate po file for help pages
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '14

03 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Priority: P5 - low Change sponsored?: --- Bug ID: 7934 Assignee: frederic(a)tamil.fr Summary: Separate po file for help pages QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer(a)bsz-bw.de Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha I propose to split the help files out of the po file for the staff interface. It would allow to prioritise while working on translations and reduce the size of our biggest po file. A possible workflow for translators then could be: 1) Translate the OPAC, because patrons come first :) 2) Translate the staff interface, so staff can start using Koha and all buttons and links have their correct translated names 3) Translate help files while being able to look at the translated interfaces for the right names of elements -- You are receiving this mail because: You are watching all bug changes.

1 19