May 2014 - Koha-bugs - lists.koha-community.org

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #20 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 28393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28393&action=edit Bug 3050 - Add an option to upload scanned invoices #3/3 (part #3: DB updates + new syspref) Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #19 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 28392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28392&action=edit Bug 3050 - Add an option to upload scanned invoices #2/3 (part #2: changes to existing acqui scripts & templates) Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28362|0 |1 is obsolete| | Attachment #28363|0 |1 is obsolete| | Attachment #28364|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 28391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28391&action=edit Bug 3050 - Add an option to upload scanned invoices #1/3 (part #1: new module w/ UT + script + template) New feature, adds an ability to attach arbitrary files to acquisition records (currently: to the invoices - but it can be extended to baskets, basketgroups, budgets etc.). Note: this code is (heavily) based on "Bug 8130 - attach PDF files to a patron record" by Kale M Hall, main difference being that new table (misc_files) and new module (Koha/Misc/Files.pm) are intended to be a little more generic solution - they allow to store and manage files associated with great many kinds of records, from arbitrary tables. Test plan: 1) Apply patch[es] 2) Run installer/data/mysql/updatedatabase.pl 3) Enable system preference 'AcqEnableFiles' in acquisition 4) New option 'Manage invoice files' appears in the invoice detail page 5) Upload/view/download/delete some files for some invoices 6) Try to delete invoice with files attached (files should get deleted as well) 7) Try to merge 2+ invoices with files attached; after merge, all files previously attached to individual invoices being merged should be attached to resulting invoice (merge destination) 8) prove t/db_dependent/Koha_Misc_Files.t 9) Ensure there are no regressions of any kind in invoice detail page (acqui/invoice.pl). Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #17 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- QA comment: 1/ I don't consider a patch should fail qa if it does not use DBIC since we don't have any recommendation on how to integrate it into Koha scripts/modules at the moment. 2/ You use a new way for ordering dates in a table, I would prefer to keep the usual method (using span title). 3/ It would be great if the variable names in the module match the DB field names (for instance record_id vs recordid vs recid). Not blocker. 4/ These patch use implicit use of conditionals: * $a || return; * defined($a) || do { some assignment }; I am not sure we have coding guidelines about that but I really would prefer the code being consistent. * return if $a; * if ( defined($a) ) { some assignment; } Not blocker. I will provide a follow-up for 2. Mared as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11716] New: Use new DataTables include in label manage template
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11716 Bug ID: 11716 Summary: Use new DataTables include in label manage template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/labels/label-manage.pl?label_element=lay out OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The label template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 11710] New: Use new DataTables include in cataloging Z39.50 search template
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11710 Bug ID: 11710 Summary: Use new DataTables include in cataloging Z39.50 search template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The cataloging Z39.50 search template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 11717] New: Use new DataTables include in member templates
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11717 Bug ID: 11717 Summary: Use new DataTables include in member templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Member templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 11789] New: Use validation plugin when creating new list
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Bug ID: 11789 Summary: Use validation plugin when creating new list Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/virtualshelves/shelves.pl?shelves=1 OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Lists Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, m.de.rooy(a)rijksmuseum.nl The new list entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/) -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 11562] New: QA: the sysprefs.sql is not correctly sorted
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Bug ID: 11562 Summary: QA: the sysprefs.sql is not correctly sorted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)biblibre.com QA Contact: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 11087] New: Have the fines tab default to pay fines rather than account
by bugzilla-daemon＠bugs.koha-community.org 21 May '14

21 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087 Bug ID: 11087 Summary: Have the fines tab default to pay fines rather than account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org A suggestion from an attendee at KohaCon13: Since paying fines is the most likely action when clicking on the Fines tab, the pay fines tab should be the default rather than the account summary. -- You are receiving this mail because: You are watching all bug changes.

1 13