March 2015 - Koha-bugs - lists.koha-community.org

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #35 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 36678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36678&action=edit [PASSED-QA] Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36644|0 |1 is obsolete| | Attachment #36645|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 36677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36677&action=edit [PASSED-QA] Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. NOTE: Tested in conjunction with my patch. However, this piece alone: - lacked unit tests since it modified C4/Review.pm - failed to provide the desired links in the email message, as mentioned in comment #1. - failed to pass biblionumber information for use in the letter as mentioned in comment #11. - passed $review, when it was really id that should have been passed and used to implement the inclusion of reviews.reviewid and other reviews table fields. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #33 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I've done again all the tests (until point 6 but I think point 6 and 7 can be done at the QA step ?) Everything works correctly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #32 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 36645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36645&action=edit Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #31 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 36644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36644&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. NOTE: Tested in conjunction with my patch. However, this piece alone: - lacked unit tests since it modified C4/Review.pm - failed to provide the desired links in the email message, as mentioned in comment #1. - failed to pass biblionumber information for use in the letter as mentioned in comment #11. - passed $review, when it was really id that should have been passed and used to implement the inclusion of reviews.reviewid and other reviews table fields. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #30 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 36643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36643&action=edit Bug 13635: Unimarc - On editing a notice, the title should be displayed The title method of MARC::Record does not deal with UNIMARC, it should not be called if the marc flavour is UNIMARC. Test plan: On an unimarc installation, edit a notice, with this patch you should see "Editing TITLE (Record number BIBLIONUMBER)" Without, the title was not displayed. Same in the breadcrumbs. Bug 13635: Remove another useless call There is another call to the title method in additem.pl without any check on the marc flavour. But here the title variable sent to the template is redefined 3 lines later. So it can be simply removed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested on UNIMARC install, editing a 'record' (not notice) does not show title on breadcrumbs, status bar or page title. With patch it does! No koha-qa errors. Signed-off-by: joel aloi <aloi54(a)live.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36629|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0