March 2015 - Koha-bugs - lists.koha-community.org

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes(a)biblibre.com --- Comment #29 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by sonia bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13558] New: In-house checkouts: optionally allow library to choose due date
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '15

06 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13558 Bug ID: 13558 Summary: In-house checkouts: optionally allow library to choose due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently the on-site checkouts due date is hardcoded the "end of today". For libraries who store the items locally for the patrons to come back and use them again, it woudl be nice if the due date could be specified manually on the circ page. circ/circulation.pl l.163-165 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36614|0 |1 is obsolete| | --- Comment #28 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36629&action=edit Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36628&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. NOTE: Tested in conjunction with my patch. However, this piece alone: - lacked unit tests since it modified C4/Review.pm - failed to provide the desired links in the email message, as mentioned in comment #1. - failed to pass biblionumber information for use in the letter as mentioned in comment #11. - passed $review, when it was really id that should have been passed and used to implement the inclusion of reviews.reviewid and other reviews table fields. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #26 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Tested on a sandbox : - go to OPAC to add a comment without filling the syspref CommentModeratorsEmail : nothing is added in message_queue table : OK - set syspref CommentModeratorsEmail with my email adress and set the syspref staffClientBaseURL - add a comment on OPAC - try SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; I have a new record : OK - reedit the comment on the OPAC - try the SQL request : 2 records : Ok - go to notices and slips : try to change the model - go to the OPAC : add a new comment - retry the SQL reequest : I have a new record with the change I made in the model : OK It works as it is described in the test plan but I have a remarks in the url to manage the comments : in the model, it's : http://<<staffClientBaseURL>>/cgi-bin/koha/review/reviewswaiting.pl? but the right URL is http://<<staffClientBaseURL>>/cgi-bin/koha/reviewS/reviewswaiting.pl? (there's a S and the end of review) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13575] New: Updating developer list.
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575 Bug ID: 13575 Summary: Updating developer list. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt(a)gmail.com Reporter: brandon_h27(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Names do not appear in the Koha history Timeline. This would be a good addition. The names to be added are: Kahurangi Cormack, Alexander Cheeseman. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #25 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Yes, you're right :-) I forgot to set the staffClientBaseURL syspref ... I'll test one more time -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36522|0 |1 is obsolete| | --- Comment #24 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36614&action=edit Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. NOTE: Improved the test plan to make staffClientBaseURL obvious. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36521|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36613&action=edit [SIGNED OFF] Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. NOTE: Tested in conjunction with my patch. However, this piece alone: - lacked unit tests since it modified C4/Review.pm - failed to provide the desired links in the email message, as mentioned in comment #1. - failed to pass biblionumber information for use in the letter as mentioned in comment #11. - passed $review, when it was really id that should have been passed and used to implement the inclusion of reviews.reviewid and other reviews table fields. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0