March 2015 - Koha-bugs - lists.koha-community.org

[Bug 4402] Date filter in parcels.tt requires db format dates
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36402|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 36549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36549&action=edit [PASSED QA] Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats Signed-off-by: Nicole <nicole(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4402] Date filter in parcels.tt requires db format dates
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13778] New: lists buttons ugly
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Bug ID: 13778 Summary: lists buttons ugly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 36309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36309&action=edit patron lists buttons The lists buttons are wrapping in some cases when there is plenty of room for them to show - makes them ugly looking. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #21 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I have just tested it. Everything is fine except that <<staffClientBaseURL>> isn't filled in the email : ... BEGIN COMMENT --- A lire absolument --- END COMMENT --- To approve: http:///cgi-bin/koha/review/reviewswaiting.pl?op=approve&reviewid=10 To delete: http:///cgi-bin/koha/review/reviewswaiting.pl?op=delete&reviewid=10 Or to review all comments: http:///cgi-bin/koha/review/reviewswaiting.pl Check it out! Your library. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #20 from M. Tompsett <mtompset(a)hotmail.com> --- Ignore comments #10 and #17. My second commit covers all that. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36517|0 |1 is obsolete| | --- Comment #19 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36522&action=edit Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<StaffBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36516|0 |1 is obsolete| | --- Comment #18 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36521&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #17 from M. Tompsett <mtompset(a)hotmail.com> --- And by the way, comment 10 is still a valid issue. I figure it might be useful to include it in the letter in the future, but no code was added to make that possible. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from M. Tompsett <mtompset(a)hotmail.com> --- Obviously item numbers and the like don't make sense in the context of this bug, but fixing what is listed for what reports would require a separate enhancement. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #15 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36517&action=edit Bug 1985 - Add missing table variables, tweak License, and cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. 6) prove -v t/db_dependent/Review.t 6) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

1 0