March 2015 - Koha-bugs - lists.koha-community.org

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36065|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 36516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36516&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '15

05 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #13 from M. Tompsett <mtompset(a)hotmail.com> --- Another reason this is currently failed qa. This modifies C4/Review.pm without adding any tests. Don't worry, the patch I'm working on for this will handle comment #11 and add tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #12 from M. Tompsett <mtompset(a)hotmail.com> --- I think that may be a cronjob configuration problem. I'll recheck this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr Status|Needs Signoff |Failed QA --- Comment #11 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I tested this patch on a sandbox : 1. set syspref CommentModeratorsEmail with my email adress 2. go to public interface and add a comment on a book 3. go to saved reports to check to table message_queue : I have a new record with the letter_code ''COMMENT_CREATED' : Ok, it works ! 4. Go to notices and slips to change the message of ''COMMENT_CREATED' model : in email tab, I try to add the title of the book in the message (<<biblio.title>>) and the biblionumber (<<biblio.biblionumber>>) 5. Go to the opac and add a new comment on an other book 6. go to saved reports to check to table message_queue : I don't retrieve the title of the book and the biblionumber in the email : it's a pity because it can be usefull informations for the librarian. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2806] issuingbranch isn't used
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2806] issuingbranch isn't used
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36124|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 36499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36499&action=edit [SIGNED-OFF] Bug 2806: Remove issuingbranch columns This column is not in used in the Koha code and could be removed. Test plan: Verify the branch is correctly displayed on the circulation history (members/readingrec.pl) and that both reports Most-cisulated items (cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as before. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> No problems found. Fixed wrong table name on updatedatabase.pl and a tab char. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13334] New: Add a warning during the return of a document that was reserved to a course.
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334 Bug ID: 13334 Summary: Add a warning during the return of a document that was reserved to a course. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: simith.doliveira(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 2499] Improvement on text wrapping algorithm needed
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard(a)gmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9897] New: members/member.pl double encoded utf-8 strings
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9897 Bug ID: 9897 Summary: members/member.pl double encoded utf-8 strings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: dpavlin(a)rot13.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Since we are doing encode all over the place if patron categories have utf-8 strings this page gets corrupted. Culprit is my @categories=C4::Category->all; which can be tested by replacing it with empty array like my @categories=() Unfortunately die to the way code is structured there is no easy solution for this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 13425] There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '15

04 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 Dobrica Pavlinusic <dpavlin(a)rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13789 -- You are receiving this mail because: You are watching all bug changes.

1 0