June 2015 - Koha-bugs - lists.koha-community.org

[Bug 5334] New: add explicit foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Summary: add explicit foreign key constraints Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Database AssignedTo: gmcharlt(a)gmail.com ReportedBy: gmcharlt(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 There are many tables that lack explicit foreign key relationships to parent tables. For example: * serial (biblionumber, subscriptionid) * subscription (biblionumber) * subscriptionhistory (biblionumber, subscriptionid) * suggestions (suggestedby, managedby, rejectedby) * branch_transfer_limits (toBranch, fromBranch) and many, many others. Explicit foreign keys should be added for several reasons: * to promote better data integrity and to expose cases where the application code makes unwarranted assumptions about the database structure * to allow cascading updates and deletes in some cases * to make it easier for external reporting tools to correctly identify relationships between tables * to make use of an ORM more effective There are some arguments against this: * a complete set of FKs may decrease database speed (on the other hand, the Koha schema already uses a bunch of FKs) There are some implementation details to consider: * the database creation scripts may need some reordering * in some cases, a database update to add an FK may require dealing with rows that do not meet the new constraint. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 12

[Bug 13518] New: Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Bug ID: 13518 Summary: Table borrower_modifications is missing FK and not deleted with the patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The table borrower_modifications has no FK constraint on the borrowernumber and will remain untouched when the patron is deleted. If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 13667] New: Provide script to regularly clean deletedpatrons table
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Bug ID: 13667 Summary: Provide script to regularly clean deletedpatrons table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Currently when a patron record is deleted in Koha the information in the table borrowers is moved to the table deletedborrowers. But Koha currently provides no way to clean up the table deletedborrowers regularly. The data is kept forever or has to be deleted via SQL. We should provide a script that checks for a timestamp (see bug 8926) and deletes data older than x days. It might also be desirable to offer an option to never save data into the deletedborrowers table. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 13515] New: Table messages is missing FK constraints and is never cleaned up
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Bug ID: 13515 Summary: Table messages is missing FK constraints and is never cleaned up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The table messages is used to store notes to the patron (visible in OPAC) and internal notes for circulation. There is no FK on the borrowernumber, so the data in this table is never cleaned up, not even on deleting the patron. There is also no FK on the branchcode, although the comments state otherwise. 2723 -- Table structure for table `messages` 2724 -- 2725 DROP TABLE IF EXISTS `messages`; 2726 CREATE TABLE `messages` ( -- circulation messages left via the patron's check out screen 2727 `message_id` int(11) NOT NULL auto_increment, -- unique identifier assigned by Koha 2728 `borrowernumber` int(11) NOT NULL, -- foreign key linking this message to the borrowers table 2729 `branchcode` varchar(10) default NULL, -- foreign key linking the message to the branches table 2730 `message_type` varchar(1) NOT NULL, -- whether the message is for the librarians (L) or the patron (B) 2731 `message` text NOT NULL, -- the text of the message 2732 `message_date` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, -- the date and time the message was written 2733 PRIMARY KEY (`message_id`) 2734 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 13533] New: Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533 Bug ID: 13533 Summary: Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The suggestions table never clears the borrowernumbers referenced in - suggestedby - managedby - acceptedby - rejectedby suggestedby is usually a patron not a staff user, I think on deletion of the patron it would make sense to set it to NULL. Maybe also for the other 3? There is also no FK on - budgetid - branchcode -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 13535] New: Table alert is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Bug ID: 13535 Summary: Table alert is missing FK and not deleted with the patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The table alert contains subscriptions for email notifications for new serial issues. There is no FK on the borrowernumber and no other permission I can see to clean the table once the patron has been deleted. 2806 DROP TABLE IF EXISTS `alert`; 2807 CREATE TABLE `alert` ( 2808 `alertid` int(11) NOT NULL auto_increment, 2809 `borrowernumber` int(11) NOT NULL default 0, 2810 `type` varchar(10) NOT NULL default '', 2811 `externalid` varchar(20) NOT NULL default '', 2812 PRIMARY KEY (`alertid`), 2813 KEY `borrowernumber` (`borrowernumber`), 2814 KEY `type` (`type`,`externalid`) 2815 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 8897] New: Optional GnuPG encryption of outgoing emails
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Priority: P5 - low Change sponsored?: --- Bug ID: 8897 Assignee: mirko(a)abunchofthings.net Summary: Optional GnuPG encryption of outgoing emails Severity: enhancement Classification: Unclassified OS: All Reporter: mirko(a)abunchofthings.net Hardware: All Status: NEW Version: rel_3_12 Component: Notices Product: Koha Koha should have an option to encrypt outgoing emails with GnuPG. -- You are receiving this mail because: You are watching all bug changes.

1 52

[Bug 11299] New: Add a button that automatically links authority records to a biblio record during edition. (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bug ID: 11299 Summary: Add a button that automatically links authority records to a biblio record during edition. (AJAX) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: fcapovilla(a)live.ca QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Created attachment 23146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23146&action=edit Add a button to the biblio edition page to automatically add authority links. This patch adds a "Link authorities automatically" button to the addbiblio page. When it's clicked, authority links are automatically added to the current biblio record without a need to save the record. A message is then shown, giving a summary of the linking process and telling the user which fields were updated and which ones were not. If some fields could not be linked, a "create authority" icon is added next to their $9 subfield. If this icon is clicked, a popup appears to let the user create a new authority record for the field. The patch also adds an optional "status" return value to Linker.pm, which can be used by the Linker to return custom status strings to give more informations about the linking process to the user. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

1 39

[Bug 11879] New: Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '16

14 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bug ID: 11879 Summary: Add a new borrower field : main contact method. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fcapovilla(a)live.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 25745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25745&action=edit Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 49

[Bug 13668] New: Creator of an SQL report shoudl be NULL when the staff patron is deleted
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '16

13 Jan '16

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Bug ID: 13668 Summary: Creator of an SQL report shoudl be NULL when the staff patron is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When deletig a staff patron his/her reports are still linked to his/her former borrowernumber. It would be better to delete the connection to the creator when the staff patron is deleted. -- You are receiving this mail because: You are watching all bug changes.

1 11