October 2016 - Koha-bugs - lists.koha-community.org

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #48 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56680&action=ed… Bug 5260: QA follow-up - Add sample ACQORDER notice to sample notices Adds the new notice ACQORDER to all web installers. Verify by testing the SQL contains no errors and by running: perl xt/sample_notices.t NOTE: - de-DE is already translated, others are in English. - xt/sample_notices.t doesn't check fr-CA yet. I didn't fix this here as the file is missing other notices as well which should be fixed separately. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #47 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Jonathan, thx for the review and catching this! I have (hopefully) fixed the problem. Can you please take a look at the follow-up patch? > Is there a good reason not to add the new ACQORDER notice? No good reason really, more an oversight! I will work on another follow-up covering it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #46 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56679&action=ed… Bug 5260: QA follow-up: Fix error when no notice template is defined When no notice template ACQORDER was defined, you'r receive a false positive "email sent" message. Now it will display a specific error message instead. Also includes 2 unit tests to test for the warn and new error code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |josef.moravec(a)gmail.com --- Comment #10 from Josef Moravec <josef.moravec(a)gmail.com> --- So it looks like this kind of issue could be in more places, is it true? I agree with you, that it would be better to fix it generally, but I have no idea, how to do it... But if we'd go with this solution, I am adding sign-off as it works as described. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #9 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 56677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56677&action=ed… Bug 14637: Followup - Fix number of tests due to rebase -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55233|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 56676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56676&action=ed… [SIGNED-OFF] Bug 14637: Fix add patron category under MySQL 5.7 If no dateofbirthrequired or upperagelimit is set on the interface, the ->store method will receive an empty string defined for these values. For INT field, we must explicitely set these empty value to undef instead to avoid MySQL 5.7 (and strict mode) to raise: DBD::mysql::st execute failed: Incorrect integer value: ' for column 'dateofbirthrequired'' Test plan: Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES) Create a patron category without specifying upperagelimit or dateofbirthrequired Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55232|0 |1 is obsolete| | Attachment #56674|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 56675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56675&action=ed… [SIGNED-OFF] Bug 14637: Fix add patron category under MySQL 5.7 - tests Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #6 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 56674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56674&action=ed… [SIGNED-OFF] Bug 14637: Fix add patron category under MySQL 5.7 - tests Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5620] Capture Mode of payment
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11682] serials.status is too dependent on magic numbers
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '16

19 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0