October 2016 - Koha-bugs - lists.koha-community.org

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace(a)sub.s | |u.se --- Comment #18 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- Without having actually tested this bug, only reading the discussion, I would say that I have to agree with Sonia. As this new date is set after the material is checked in, it doesn't appear (at least to me) that the expire date set by the patron would be valuable anymore. And the added value of excluding dates that the library is closed from the number of day in ReservesMaxPickUpDelay, seem greater than any negative impact. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #28 from Lari Taskula <lari.taskula(a)jns.fi> --- Moved permissions into Swagger and added tests for accessing own accountlines. Tests are failing for me for paying, but it is probably reasonable to wait until rest of the Koha::Account patches has been pushed before doing more for this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55035|0 |1 is obsolete| | --- Comment #27 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 56696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56696&action=ed… Bug 15165 - Add API routes to pay accountlines POST /accountlines/(:accountlines_id)/payment (pay towards accountline) POST /patrons/(:borrowernumber)/payment (pay towards borrower) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You must have permission updatecharges. 2. Create a fine to any patron and get the accountlines_id. 3. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment without body where YYY is the accountlines_id you created in step 2. 4. Check that the accountline that you created in step 2 is paid. 5. Create two payments with amount 5.00 (with no other outstanding payments) 6. Send POST request to http://yourlibrary/api/v1/patrons/ZZZ/payment with body {"amount": 10} Replace ZZZ with the borrowernumber for which you have created two fines 7. Check that the two accountlines are paid. 8. Repeat step 2. 9. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment with body {"amount": XXX} Replace YYY with the accountlines_id you created in step 8. Set amount (XXX) to the half of the amount of the fine you created in step 8. 10. Check that the fine is still outstanding with half of the original amount. 11. Run unit tests at t/db_dependent/api/v1/accountlines.t and t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55034|0 |1 is obsolete| | --- Comment #26 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 56695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56695&action=ed… Bug 15165 - Add API route to edit accountlines PUT /accountlines/{accountlines_id} (edit) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY where YYY is one of your accountlines_id. See the body definition in definitions/editAccountlineBody.json and use this in your PUT request. 3. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55033|0 |1 is obsolete| | --- Comment #25 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 56694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56694&action=ed… Bug 15165 - Add API route to list accountlines GET /accountlines (list) GET /accountlines?borrowernumber=X (list) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace XXX with a borrowernumber that has accountlines) and check you receive correct data 3. Go to http://yourlibrary/api/v1/accountlines and check that you receive all accountlines 4. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marc Véron from comment #17) > Additionally, I think that the new function in C4/Auth.pm would need some > testing in t/db_dependent/Auth.t Nicholas, Please add some unit tests. Changing status to reflect need for change. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #54 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #53) > Katrin, > Could you have a look at the 4 patches please? They should not introduce any > regression. > I am wondering if we should not add a confirmation box as the button will > sent an email. > I also think that the button should not be displayed if the vendor does not > have any email address defined, don't you think? Hi Jonathan, thx for the follow-ups! I will test them later, but they all look good to me and make sense. I was modeling this from the way we send e-mails for claims. I am not against a confirmation box, I can try to take a look at how this is done on other pages. Arguments for showing the button: The user gets an informative message, that they need to edit a vendor contact in order to make it work. Also: I am not sure how to achieve hiding it correctly :( The logic here is not as simple as checking for an email address in the vendor, as there can be multiple contacts and the SendAlerts give priority to the one that is acqprimary and has the right option checked (Take a look at the SQL in SendAlerts). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Josef Moravec from comment #12) > Maybe I unterstand it wrong but 17080 handles NOT NULL columns and > upperagelimit and dateofbirthrequired are nullable... Yes sorry, not enough tea this morning. This patch makes sense but we could reuse the same logic for date and int fields (if equal '', then set to undef). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Jonathan Druart from comment #11) > (In reply to Josef Moravec from comment #10) > > So it looks like this kind of issue could be in more places, is it true? > > > > I agree with you, that it would be better to fix it generally, but I have no > > idea, how to do it... > > > > But if we'd go with this solution, I am adding sign-off as it works as > > described. > > Could you prove the tests from this bug without the changes to > Koha::Patron::Category->store and apply bug 17080 and see if they pass with > MySQL5.7? I tried, but unfortunately, the test failed with this error message: t/db_dependent/Koha/Patron/Categories.t .. 1/8 DBD::mysql::st execute failed: Incorrect integer value: '' for column 'dateofbirthrequired' at row 1 [for Statement "INSERT INTO `categories` ( `category_type`, `categorycode`, `dateofbirthrequired`, `description`, `upperagelimit`) VALUES ( ?, ?, ?, ?, ? )" with ParamValues: 0='A', 1='mycatcodeW', 2='', 3='mycatdescW', 4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'dateofbirthrequired' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 119 # Looks like your test exited with 255 just after 8. t/db_dependent/Koha/Patron/Categories.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 8 subtests passed Test Summary Report ------------------- t/db_dependent/Koha/Patron/Categories.t (Wstat: 65280 Tests: 8 Failed: 0) Non-zero exit status: 255 Files=1, Tests=8, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.51 cusr 0.27 csys = 0.79 CPU) Result: FAIL Maybe I unterstand it wrong but 17080 handles NOT NULL columns and upperagelimit and dateofbirthrequired are nullable... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10498] Place Hold on Order
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com, | |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0