October 2016 - Koha-bugs - lists.koha-community.org

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Jonathan Druart from comment #11) > (In reply to Josef Moravec from comment #10) > > So it looks like this kind of issue could be in more places, is it true? > > > > I agree with you, that it would be better to fix it generally, but I have no > > idea, how to do it... > > > > But if we'd go with this solution, I am adding sign-off as it works as > > described. > > Could you prove the tests from this bug without the changes to > Koha::Patron::Category->store and apply bug 17080 and see if they pass with > MySQL5.7? I tried, but unfortunately, the test failed with this error message: t/db_dependent/Koha/Patron/Categories.t .. 1/8 DBD::mysql::st execute failed: Incorrect integer value: '' for column 'dateofbirthrequired' at row 1 [for Statement "INSERT INTO `categories` ( `category_type`, `categorycode`, `dateofbirthrequired`, `description`, `upperagelimit`) VALUES ( ?, ?, ?, ?, ? )" with ParamValues: 0='A', 1='mycatcodeW', 2='', 3='mycatdescW', 4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'dateofbirthrequired' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 119 # Looks like your test exited with 255 just after 8. t/db_dependent/Koha/Patron/Categories.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 8 subtests passed Test Summary Report ------------------- t/db_dependent/Koha/Patron/Categories.t (Wstat: 65280 Tests: 8 Failed: 0) Non-zero exit status: 255 Files=1, Tests=8, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.51 cusr 0.27 csys = 0.79 CPU) Result: FAIL Maybe I unterstand it wrong but 17080 handles NOT NULL columns and upperagelimit and dateofbirthrequired are nullable... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10498] Place Hold on Order
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com, | |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12769] Notice fee management
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Katrin, Could you have a look at the 4 patches please? They should not introduce any regression. I am wondering if we should not add a confirmation box as the button will sent an email. I also think that the button should not be displayed if the vendor does not have any email address defined, don't you think? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #52 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56689&action=ed… Bug 5260: Use post params instead of get to avoid putting op=email in the browser history -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #51 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56688&action=ed… Bug 5260: simplify script and error handling No need to redirect, just sent the params to the template directly -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56687&action=ed… Bug 5260: Insert the new letter for existing installs -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56686&action=ed… Bug 5260: make tests pass even without patron cat 'PT' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 [Bug 17472] Borrower Previously Checked Out: Display title -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '16

20 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17471 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17471 [Bug 17471] Borrower Previously Checked Out: Date of last checkout -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0