October 2016 - Koha-bugs - lists.koha-community.org

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56962&action=ed… Bug 15581: Display the latest auto renew date possible when renewing manually If an issue marked as auto_renew is renewed manually, we want to display the latest auto renew date possible. Test plan: 1/ Define circ rules as in the previous patch. 2/ Check a item out, mark it as an auto renewal 3/ Back date the issuedate and make sure it will be too late to renew it 4/ Use the Circulation > renew page (circ/renew.pl) to manually renew this issue. You should get a warning "You barcode has been scheduled for automatic renewal and cannot be renewed anymore since DATE." If the pref AllowRenewalLimitOverride is set, you will be allowed to renew it anyway. Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field <jonathan.field(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56746|0 |1 is obsolete| | Attachment #56747|0 |1 is obsolete| | Attachment #56748|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56961&action=ed… Bug 15581: Add a circ rule to limit the auto renewals given a delay This patch adds a new circulation rule (no_auto_renewal_after) to block/allow auto renewals after a given delay. For instance, if the issue date is 10 days before today, and no_auto_renewal_after is set to 10, tomorrow the issue won't be auto renewed. Test plan: 0/ Execute the update DB entry Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Define a rule with no_auto_renewal_after (10 for instance) and norenewalbefore (5 for instance). (This new rule will behave the same as norenewalbefore: the unit depends on the lengthunit value). The automatic renewals will be done from 5 to 10 days ahead. 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed (too soon) 4/ Repeat step 2 with a due date set as 11 days before 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed (too late) 6/ Repeat step 2 with a due date set as 7 days before 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed (issues.renewals has been incremented and date_due has been updated according your circ rules). Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field <jonathan.field(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #108 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56959&action=ed… Bug 13321: Fix tests in Budgets.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Janet McGowan <janet.mcgowan(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan(a)ptfs-europe.c | |om --- Comment #41 from Janet McGowan <janet.mcgowan(a)ptfs-europe.com> --- (In reply to Jonathan Druart from comment #40) > (In reply to Katrin Fischer from comment #39) > > Writing a quick summary about how this works for the next reader: > > In the circulation conditions there is a new value "no automatic renewal > > after". This means that "after you have checked out the item for more than X > > days, there will be no more automatic renewals". > > > > Ok, 2 things: > > > > 1) Couldn't test in the OPAC, because of: > > Software error: > > > > Template process failed: undef error - The method is_expired is not covered > > by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. > > > > For help, please send mail to the webmaster ([no address given]), giving > > this error message and the time and date of the error. > > Exists on master and will be fixed by bug 17517. > > > 2) In the circulation interface it will show "Scheduled for automatic > > renewal" when this won't happen again because the item has already been > > checked out for too long. I think this will lead to confusion. Could we make > > this message more specific? > > What do you suggest? Something like "Can no longer be auto-renewed - number of checkout days exceeded" ?(In reply to Jonathan Druart from comment #40) > (In reply to Katrin Fischer from comment #39) > > Writing a quick summary about how this works for the next reader: > > In the circulation conditions there is a new value "no automatic renewal > > after". This means that "after you have checked out the item for more than X > > days, there will be no more automatic renewals". > > > > Ok, 2 things: > > > > 1) Couldn't test in the OPAC, because of: > > Software error: > > > > Template process failed: undef error - The method is_expired is not covered > > by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. > > > > For help, please send mail to the webmaster ([no address given]), giving > > this error message and the time and date of the error. > > Exists on master and will be fixed by bug 17517. > > > 2) In the circulation interface it will show "Scheduled for automatic > > renewal" when this won't happen again because the item has already been > > checked out for too long. I think this will lead to confusion. Could we make > > this message more specific? > > What do you suggest? (In reply to Jonathan Druart from comment #40) > (In reply to Katrin Fischer from comment #39) > > Writing a quick summary about how this works for the next reader: > > In the circulation conditions there is a new value "no automatic renewal > > after". This means that "after you have checked out the item for more than X > > days, there will be no more automatic renewals". > > > > Ok, 2 things: > > > > 1) Couldn't test in the OPAC, because of: > > Software error: > > > > Template process failed: undef error - The method is_expired is not covered > > by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. > > > > For help, please send mail to the webmaster ([no address given]), giving > > this error message and the time and date of the error. > > Exists on master and will be fixed by bug 17517. > > > 2) In the circulation interface it will show "Scheduled for automatic > > renewal" when this won't happen again because the item has already been > > checked out for too long. I think this will lead to confusion. Could we make > > this message more specific? > > What do you suggest? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13323] Change the tax rate on receiving
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan, Julian! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #107 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks everyone! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #39) > Writing a quick summary about how this works for the next reader: > In the circulation conditions there is a new value "no automatic renewal > after". This means that "after you have checked out the item for more than X > days, there will be no more automatic renewals". > > Ok, 2 things: > > 1) Couldn't test in the OPAC, because of: > Software error: > > Template process failed: undef error - The method is_expired is not covered > by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. > > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error. Exists on master and will be fixed by bug 17517. > 2) In the circulation interface it will show "Scheduled for automatic > renewal" when this won't happen again because the item has already been > checked out for too long. I think this will lead to confusion. Could we make > this message more specific? What do you suggest? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17517 [Bug 17517] "your summary" page in OPAC is broken -- You are receiving this mail because: You are watching all bug changes.

1 0