October 2016 - Koha-bugs - lists.koha-community.org

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49986|0 |1 is obsolete| | --- Comment #125 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56949&action=ed… Bug 14598 [QA Followup] - Update localuse statistics also Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49985|0 |1 is obsolete| | --- Comment #124 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56948&action=ed… Bug 14598 [QA Followup] - Make unit test pass Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49984|0 |1 is obsolete| | --- Comment #123 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56947&action=ed… Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49983|0 |1 is obsolete| | --- Comment #122 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56946&action=ed… Bug 14598 [QA Followup] - Only fetch bib data if needed Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49982|0 |1 is obsolete| | --- Comment #121 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56945&action=ed… Bug 14598 - QA Followup touching CanBookBeIssued subroutine Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49981|0 |1 is obsolete| | --- Comment #120 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56944&action=ed… Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49980|0 |1 is obsolete| | --- Comment #119 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56943&action=ed… Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49979|0 |1 is obsolete| | --- Comment #118 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56942&action=ed… Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49978|0 |1 is obsolete| | --- Comment #117 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56941&action=ed… Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #116 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0