October 2016 - Koha-bugs - lists.koha-community.org

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54280|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56956&action=ed… Bug 14629 - (QA Followup) sysprefs.sql changes Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51029|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56955&action=ed… Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. Signed-off-by: Chad Roseburg <croseburg(a)ncrl.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51028|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56954&action=ed… Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org Signed-off-by: Chad Roseburg <croseburg(a)ncrl.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #130 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Code looks good to me. > it could be great to execute the update DB entry on a large DB Months passed by in the meantime and nothing happened. I think that some more test coverage on the smaller changes in essential circulation routines is crucial too now. As expected, the dbrev warns on items too that are not found in both items as well as deleteditems. (We could probably do without them..) Several tests are flooded now with: item-level_itypes set but no itemtype set for item (2144749608) at /usr/share/koha/masterclone/Koha/Schema/Result/Item.pm line 698. Especially Circulation.t Note that this comes from creating items without itemtype in these tests. We should adjust those tests. In the actual logs I do not hope/expect to see this warning ;) Passed QA RM: Push now or wait. The dbrev is already in updatedatabase. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #129 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56953&action=ed… Bug 14598: [QA Follow-up] Small changes [1] Renames the dbrev version to XXX; adding a my for $sth, although not strictly necessary it feels better. [2] Circulation.t stumbles over: Undefined subroutine &C4::Circulation::GetItem called at ... line 1283. Somehow this is related to use_ok instead of a regular use. Worked around this by require_ok and adding a regular use. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50018|0 |1 is obsolete| | --- Comment #128 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56952&action=ed… Bug 14598: Fix warning from effective_itemtype Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49988|0 |1 is obsolete| | --- Comment #127 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56951&action=ed… Bug 14598: (QA followup) use deleted{items|biblioitems} during upgrade If the 'statistics' table contains circulation information about items that are no longer on the DB it will raise a warning. This patch makes the updatedatabase.pl script use the deleteditems and deletedbiblioitems tables to get information for those items on the statistics table. To reproduce: - Have your sample DB contain some circulation data on the statistics table - Make sure some of them have NULL itemtype: > UPDATE statistics SET itemtype = NULL WHERE type='return'; - Check the upgrade query catches them: > SELECT s.itemnumber, i.itype, b.itemtype FROM ( SELECT DISTINCT itemnumber FROM statistics WHERE ( type = "return" OR type = "localuse" ) AND itemtype IS NULL ) s LEFT JOIN ( SELECT itemnumber,biblionumber, itype FROM items UNION SELECT itemnumber,biblionumber, itype FROM deleteditems ) i ON (s.itemnumber=i.itemnumber) LEFT JOIN ( SELECT biblionumber, itemtype FROM biblioitems UNION SELECT biblionumber, itemtype FROM deletedbiblioitems ) b ON (i.biblionumber=b.biblionumber); +------------+-------+----------+ | itemnumber | itype | itemtype | +------------+-------+----------+ | 732 | BK | BK | | 731 | BK | BK | +------------+-------+----------+ 2 rows in set (0.00 sec) - Delete the items, and some biblio too. - Re-run the query => SUCCESS: Same results - Go reset to NULL the itemtypes > UPDATE statistics SET itemtype = NULL WHERE type='return'; - Run the updatedatabase.pl script: $ sudo koha-shell koahdev ; cd kohaclone $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: No warnings Note: It is possible that on production sites, if the sysadmin is cleaning the deleted{items|biblioitems|biblio} tables, there will be warnings. This is expected as they need to know some data lacks information. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '16

28 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49987|0 |1 is obsolete| | --- Comment #126 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 56950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56950&action=ed… Bug 14598: (followup) Remove unused and non-existent C4::ItemType include Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0