November 2016 - Koha-bugs - lists.koha-community.org

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17677 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Bug 17677 - Move C4::Circulation code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677 [Bug 17677] Move C4::Circulation code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #66 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- All the indentation changes make this patchset really hard to read, but basically it seems that there are only 2 changes: 1/ Add + $MARCfrom ||= GetAuthority($mergefrom); + $MARCto ||= GetAuthority($mergeto); in C4::AuthoritiesMarc::merge In which cases that could be useful? 2/ Move DelAuthority to C4::AuthoritiesMarc::merge Sounds ok, but should not change anything in the behavior. So, why all these changes just for that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13371] Add filters to the supplier list view
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #71 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This is a hard one for QA imo. We need some feedback from people actually working with acquisitions here, or interface design experts. Do they view this as an improvement? Some of the filters for instance basket number or date seem to be handy. The vendor name is not as prominently visible as it was. Improve? I did not test with much data. Seems to be no paging? Filter on date will make it easier. The distinction between simple and complete view makes not much sense to me. I read the request for it. But this view is so 'simple' that I am not sure if it is of real use. Note that you cannot change between both if you found only one vendor. Would storing the filter values in the cookie be helpful? Not sure.. Should you toggle between "Show active and inactive baskets | Show opened baskets only" instead of showing both? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57766&action=ed… Bug 14699: Reword "Select all/Clear all" and change their behaviour "Select all" -> "Select all visible rows" "Clear all" -> "Clear selection on visible rows" + fix the bug where the Delete link was visually enabled only if you checked a box in the first page (now every checkbox enable the link) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57765&action=ed… Bug 14699: Show number of selected searches in search history With the number displayed, it should remove the ambiguity about what "Select all" and "Clear all" do. The number is repeated in the "Delete" confirmation dialog. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42330|0 |1 is obsolete| | Attachment #57684|0 |1 is obsolete| | Attachment #57685|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57764&action=ed… Bug 14699: Fix intranet search history issues due to pagination DataTables removes hidden rows from the DOM. Because of that, "Select all", "Clear all" and the form submission don't work correctly (basically they act only on the currently displayed page). This patch fixes just that. Test plan: 1/ Go to your search history page 2/ Make you sure you have at least 21 entries in your search history. If not, do some searches and come back here. 3/ Click "Select all" and change page. The checkboxes on the new page should be checked. 4/ Check some checkboxes on this new page and click "Clear all". Go back to the previous page, checkboxes shouldn't be checked. 5/ Check some checkboxes on at least 2 different pages and click "Delete". All selected search history entries should be deleted. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #13) > (In reply to Jonathan Druart from comment #11) > > Hi Aleisha, > > The getter and setter subroutines (GetIssue, SetIssueNote, SendIssueNote, > > GetPatronNote) should not be added to C4 but use Koha::Issue[s] instead. Let > > me know if you need help to do so. > > And you won't have to provide new tests ;) > > Ideally the svc script should not be added, but you should use the REST API > > instead. However the routes for checkins do not exist yet. > > Hi Jonathan, > > My latest patch moves those subroutines into Koha::Issue. Are you sure we > don't need tests? By using Koha::Issue I meant using it as an object (so no need to add you subroutine to the module). For instance: $issue = Koha::Issue::GetIssue({issue_id => $issue_id}); could be $issue = Koha::Issues->find( $issue_id); and $issue becomes a Koha::Object-based object, not an hashref SetIssueNote($issue_id, $clean_note) could be Koha::Issues->find( $issue_id )->set({ notedate => dt_from_string, note = $clean_note })->store; etc. -- You are receiving this mail because: You are watching all bug changes.

1 0