November 2016 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #13 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to Jonathan Druart from comment #11) > Hi Aleisha, > The getter and setter subroutines (GetIssue, SetIssueNote, SendIssueNote, > GetPatronNote) should not be added to C4 but use Koha::Issue[s] instead. Let > me know if you need help to do so. > And you won't have to provide new tests ;) > Ideally the svc script should not be added, but you should use the REST API > instead. However the routes for checkins do not exist yet. Hi Jonathan, My latest patch moves those subroutines into Koha::Issue. Are you sure we don't need tests? I think we'll leave the svc stuff in the checkins file for now while the routes for checkins do not exist. I will now be working on the fallback form for browsers without JS. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57577|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 57763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57763&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Make sure the branch has an email address specified 4) Check out an item to a patron 5) Log in with the patron you checked out the item for 6) In "your summery", write a message in the new "Note" field for the item checked out. Hit ENTER to save/send. 7) Success message should be seen and an email sent to the email address specified for the branch which the item was checked out from. 8) Log in with staff account and check in the item 9) The note should be shown The note can be changed by the patron at any time while the item is checked out. Each change will send a new email to the branch. Only the latest note version will be shown on check in. =============================================================================== UPDATE 4: - This patch is still not ready for testing - am committing and attaching just to keep track of my changes. - So far I have - moved the ajax code into svc/patron_notes. - made use of the built-in letters and notices functions to send this email etc (easier to test, removes a lot of unnecessary code etc), so I have removed the opac-sendissuenote.tt file and instead added a note to the database in 'letters' table which will be added to the message queue when the note is submitted - GetIssue subroutine to return the matching issue - Created a new GetPatronNote subroutine to fetch the notes on the circulation.pl page (previously the librarian could only see the note on checkin on the returns.pl page, which is not the only place you can check in) - Moved getter and setter subroutines into Koha::Issue (as per Jonathan's comments in Comment 11) - Testing: - Schema needs to be rebuilt before testing - Turn on 'AllowIssueNote' syspref - Show message_queue in mysql to test the notice is being sent - Still to do: - fallback form for browsers without JS - Show patron notes on the staff client dashboard (the way suggestions and patron detail updates show up on the main page) so librarians can mark notes as 'seen' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13665] Retrieve facets from zebra is slow
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '16

25 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Hugo Agud from comment #4) > Hope it helps That's really interesting! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11944] Cleanup Koha UTF-8
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676 [Bug 17676] Default COLLATE for marc_subfield_structure is not set -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56980|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57740&action=ed… Bug 15582: Fix grammar in syspref description -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56979|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57739&action=ed… Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached If a patron owes more than the OPACFineNoRenewals value, the issue won't be auto renewed anymore (driven by the new pref OPACFineNoRenewalsBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the OPACFineNoRenewals to 5 (for instance) 2/ Set OPACFineNoRenewalsBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set OPACFineNoRenewalsBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56978|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57738&action=ed… Bug 15582: DB changes - add new pref OPACFineNoRenewalsBlockAutoRenew Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11577] Automatic renewals
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #130 from Holger Meißner <h.meissner.82(a)web.de> --- Created attachment 57734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57734&action=ed… Explanation for "no renewal before" Hi David, it's been a while since I wrote the feature. At some point I made this little table. I hope it's still accurate and answers your questions. If not, I'll try and take a deeper look. Feel free to include the table into any documentation if it's helpful. I agree that "No renewal allowed until X units before due date" is a much better description than "no renewal before." -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6271] GetItemIssue(s) : renewals in both items and issues tables
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271 --- Comment #11 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- (In reply to Jonathan Druart from comment #10) > Would you agree to remove it? Yep -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9163] Cataloguing validation workflow
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '16

24 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers(a)biblibre.co |alex.arnaud(a)biblibre.com |m | -- You are receiving this mail because: You are watching all bug changes.

1 0