November 2016 - Koha-bugs - lists.koha-community.org

[Bug 10760] Use Street Number and Street type in Alternate Address section
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 [Bug 17559] Invalid ID of element B_streetnumber in member edit form -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12359] hidepatronname doesn't hide on the holds queue
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56847|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57637&action=ed… Bug 12359: Add HidePatronName functionality to the holds queue This changes the Holds Queue page to not show the patron's name and phone number, but only the cardnumber, when HidePatronName is set to 'Don't show' This also changes the link to the patron account to use the borrowernumber instead of the cardnumber, which seems more consistent. Fixes a tiny capitalization error: Only item... To test: - Look at the holds queue page with holds displayed - Toggle HidePatronName system preference and observe the change - Make sure the link works correctly Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Rebased 2016-10-16 Signed-off-by: Chris Kirby <christopherlawrencekirby(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12359] hidepatronname doesn't hide on the holds queue
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Great catch Kyle! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56463|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57636&action=ed… Bug 14736 - AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds If the AllowRenewalIfOtherItemsAvailable sys pref is set to allow, and a borrower has an item checked out that has many items {30+} AND many holds {70+) on it, loading the checkouts table for this borrower takes FOREVER to load. The load time takes forever, because of the factoring that happens to determine if an item is truly available for renewal. This patch swaps the use of GetMemberDetails for GetMember and reorders the subroutine calls to check each items' renewability from fastest to slowest. In a test case, the results of pre patch were: Start of loop: 2016-08-24T11:05:14 End of loop: 2016-08-24T11:05:29 Resulting in 15 seconds being spent in the loop Post patch results were: Start of loop: 2016-08-24T11:08:43 End of loop: 2016-08-24T11:08:48 Resulting in only 5 seconds being spent in the loop! Test Plan: 1) Apply this patch 2) Note there are no changes in functionality for the renewals column of the patron checkouts table. If you wish to go further and test the performance benefit: 1) Create a record with 50 items and 100 holds ( 50 waiting, 50 unfilled ) 2) Check out one of the waiting holds to a patron 3) Time the amount of time it takes for the checkouts table to load 4) Apply this patch 5) Repeat step 3, you should see an improvement in load time Signed-off-by: Jesse Maseto <jesse(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 18 Nov '16

18 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 [Bug 17657] Item type's images could not be displayed correctly on the item types admin page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17431] New: REST API: Fix failing test t/db_dependent/api/v1/holds.t
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17431 Bug ID: 17431 Summary: REST API: Fix failing test t/db_dependent/api/v1/holds.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org $ perl t/db_dependent/api/v1/holds.t ... not ok 42 - similar match for JSON Pointer "/error" # Failed test 'similar match for JSON Pointer "/error"' # at t/db_dependent/api/v1/holds.t line 291. # 'Reserve cannot be placed. Reason: itemAlreadyOnHold' # doesn't match '(?^u:tooManyReserves)' # Looks like you failed 1 test of 42. not ok 4 - Test endpoints with permission # Failed test 'Test endpoints with permission' # at t/db_dependent/api/v1/holds.t line 294. # Looks like you failed 1 test of 4. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 36

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17653 [Bug 17653] Remove itemtype-related t/db_dependent/Circulation* warnings -- You are receiving this mail because: You are watching all bug changes.

1 0