November 2016 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hi Aleisha, The getter and setter subroutines (GetIssue, SetIssueNote, SendIssueNote, GetPatronNote) should not be added to C4 but use Koha::Issue[s] instead. Let me know if you need help to do so. And you won't have to provide new tests ;) Ideally the svc script should not be added, but you should use the REST API instead. However the routes for checkins do not exist yet. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #113 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- I guess whoever comes second will have to resolve a minor conflict. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #112 from M. Tompsett <mtompset(a)hotmail.com> --- How might this interact with bug 17527? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54452|0 |1 is obsolete| | --- Comment #111 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57583&action=ed… bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54451|0 |1 is obsolete| | --- Comment #110 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57582&action=ed… bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54450|0 |1 is obsolete| | --- Comment #109 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57581&action=ed… bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54449|0 |1 is obsolete| | --- Comment #108 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57580&action=ed… bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54448|0 |1 is obsolete| | --- Comment #107 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57579&action=ed… bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54447|0 |1 is obsolete| | --- Comment #106 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57578&action=ed… bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - added sort_by input param to GetItemsInfo() * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes.

1 0