November 2016 - Koha-bugs - lists.koha-community.org

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54451|0 |1 is obsolete| | --- Comment #110 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57582&action=ed… bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54450|0 |1 is obsolete| | --- Comment #109 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57581&action=ed… bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54449|0 |1 is obsolete| | --- Comment #108 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57580&action=ed… bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54448|0 |1 is obsolete| | --- Comment #107 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57579&action=ed… bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54447|0 |1 is obsolete| | --- Comment #106 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 57578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57578&action=ed… bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - added sort_by input param to GetItemsInfo() * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '16

17 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57440|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 57577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57577&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Make sure the branch has an email address specified 4) Check out an item to a patron 5) Log in with the patron you checked out the item for 6) In "your summery", write a message in the new "Note" field for the item checked out. Hit ENTER to save/send. 7) Success message should be seen and an email sent to the email address specified for the branch which the item was checked out from. 8) Log in with staff account and check in the item 9) The note should be shown The note can be changed by the patron at any time while the item is checked out. Each change will send a new email to the branch. Only the latest note version will be shown on check in. =============================================================================== UPDATE 3: - This patch is still not ready for testing - am committing and attaching just to keep track of my changes. - So far I have - moved the ajax code into svc/patron_notes. - made use of the built-in letters and notices functions to send this email etc (easier to test, removes a lot of unnecessary code etc), so I have removed the opac-sendissuenote.tt file and instead added a note to the database in 'letters' table which will be added to the message queue when the note is submitted - GetIssue subroutine to return the matching issue - Created a new GetPatronNote subroutine to fetch the notes on the circulation.pl page (previously the librarian could only see the note on checkin on the returns.pl page, which is not the only place you can check in) - Testing: - Schema needs to be rebuilt before testing - Turn on 'AllowIssueNote' syspref - Show message_queue in mysql to test the notice is being sent - Still to do: - tests for new subroutines - fallback form for browsers without JS - Show patron notes on the staff client dashboard (the way suggestions and patron detail updates show up on the main page) so librarians can mark notes as 'seen' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '16

16 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #105 from M. Tompsett <mtompset(a)hotmail.com> --- Sorry for being slow on the draw. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] publisher code and publication year not fetched in acq orders
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '16

16 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #30 from M. Tompsett <mtompset(a)hotmail.com> --- Eyeballs fine, but seeing as a test plan written for a person who is brand new to Koha isn't available (because I am just a programmer, not a librarian), I can't test this properly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] publisher code and publication year not fetched in acq orders
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '16

16 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44712|0 |1 is obsolete| | --- Comment #29 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 44712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44712 Bug 11122: Follow up Bug 17562 removed the code that checked the structure of the Acquisitions table. No need for this patch. -- You are receiving this mail because: You are watching all bug changes.

1 0