November 2016 - Koha-bugs - lists.koha-community.org

[Bug 7029] searching : fuzzy et steming
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029 --- Comment #7 from Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> --- Created attachment 57310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57310&action=ed… searchingtab_syspref Hi Fridolin, Here is a screenshot for sys pref. Regards, Marjorie -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- Thanks for rebasing! I started to test and here are first comments When receiving shipment (script parcel.pl) I got this error: "The method listinct is not covered by tests!" In tests: t/db_dependent/Bookseller.t fails with Can't locate object method "new" via package "Koha::Acquisition::Bookseller::Contact" (perhaps you forgot to load "Koha::Acquisition::Bookseller::Contact"?) at t/db_dependent/Bookseller.t line 686. t/db_dependent/Contract.t fails with Can't locate object method "new" via package "Koha::Acquisition::Bookseller" (perhaps you forgot to load "Koha::Acquisition::Bookseller"?) at t/db_dependent/Contract.t line 42. t/db_dependent/Letters.t fails with "my" variable $bookseller masks earlier declaration in same scope at t/db_dependent/Letters.t line 418. and Can't locate object method "new" via package "Koha::Acquisition::Bookseller::Contact" (perhaps you forgot to load "Koha::Acquisition::Bookseller::Contact"?) at t/db_dependent/Letters.t line 379. All other Acquisition test are passing - I am testing on top of 17562, 17563 and 17564 I tried all related (I hope) tests, and in ui I tested Vendor, Contracts, Baskets adding to order, and so on... I will continue after the error in parcel.pl will be fixed, thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17518] New: Displayed language name for Czech is wrong
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17518 Bug ID: 17518 Summary: Displayed language name for Czech is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr It's "Ceština" and should be "Čeština" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 17504] New: Installer shows PostgreSQL info when wrong DB permissions
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17504 Bug ID: 17504 Summary: Installer shows PostgreSQL info when wrong DB permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 56873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56873&action=ed… Screenshot Steps to reproduce: - Make sure the DB user doesn't have all required privileges - Delete then create the DB - Run the installer => FAIL: PostgreSQL information shown (as in the attachment) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 4880] koha-remove sometimes fails because user is logged in
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #16 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 17434] New: Moremember displaying primary and secondary phone number twice
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Bug ID: 17434 Summary: Moremember displaying primary and secondary phone number twice Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: bc(a)interleaf.ie QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Under certain circumstances the Primary and Secondary Phone will appear twice on the Patron record. When looking at the moremember.tt file line 236 has an IF block that displays the Primary and Secondary Phone value if the category_code ="P". I can't see any documentation as to why this is and what the "P" might mean. If a site adds their own category code and it equals "P", this duplication will occur. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 17417] New: Correct invalid markup around news on the staff client home page
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Bug ID: 17417 Summary: Correct invalid markup around news on the staff client home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org There are a couple of HTML validation errors in the area of the staff client home page template related to displaying news. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 17376] New: rebuild_zebra.pl in daemon mode no database access kills the process
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17376 Bug ID: 17376 Summary: rebuild_zebra.pl in daemon mode no database access kills the process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz When running rebuild_zebra.pl in daemon mode, a while loop runs the script for ever. But if something crashes inside the rebuild process, the all daemon crashes. For example when it can not access database. This problem may be temporary so daemon should keep running. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger <matthias.meusburger(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '16

08 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger <matthias.meusburger(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45477|0 |1 is obsolete| | --- Comment #54 from Matthias Meusburger <matthias.meusburger(a)biblibre.com> --- Created attachment 57296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57296&action=ed… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0