February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14713] remaining_permissions permission under the "updatecharges" permission not working
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #3 from Julian Maurice <julian.maurice(a)biblibre.com> --- Which version of Koha do you use ? Tested on current master with a borrower that have only permissions: 'catalogue', 'borrowers' and 'updatecharges' > 'remaining_permissions'. I can't write off any fine, but I can collect fine. Also, I think the requirement for borrowers permission is by design, because how can you access borrower's fines without it ? By the way, 'borrowers' permission's description has been reworded to "Add, modify and view patron information". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #18 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Magnus Enger from comment #16) > Looks like Mark forgot to change the status. :-) No, I figured since I squashed my changes in, that a secondary sign would be a good idea. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Hi, Does anybody still work on that ? It will be great that the number of day in ReservesMaxPickUpDelay take into account only the open days of the library. If a patron have 3 days to pick up his hold and that the libray is closed 2 days just after, he will have juste one day left... Thank you Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #10 from Nick Clemens <nick(a)bywatersolutions.com> --- I don't believe so as they don't use either at NEKLS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #8 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- I'm wondering if the third option on AllowOnShelfHolds is supposed to fix a technical issue or a pedagogical one? If it's the first it might be the way to go, but if it's the second I'm not so sure it helps (as I mentioned in my previous comment). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace(a)sub.s | |u.se --- Comment #7 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- Last week I wrote a rather lengthy comment about how I don't see how AllowOnShelfHolds and the proposed AllowHoldIfOtherAvailable are necessarily the same thing and should be kept as two separate sysprefs. But in writing I got unsure if my original concerns are correct. I went through some various setting on the two sysprefs and how I envision they would work together with some tests of how they are handled by the patch now (pasted at the bottom for reference, for those interested - everyone else can skip them). My basic reservation against placing a third option on AllowOnShelfHolds is that there are libraries who don't want to allow on shelf holds that might want to only allow holds when all items are checked out. But I came to realize that the third option would in effect means no on shelf holds. What I wonder though is how a third option for AllowOnShelfHolds would affect connected patches, like bug 15532, and other hold options? I'm having a hard time envisioning the extended effects of such a change. Any thought's there is greatly appreciated! A use case to centre this discussion around: at Stockholm University Library the general rule is that placing holds is only possible when all item are checked out; and no shelf holds allowed. Holds are limited per branch: only holds that have the same pick-up branch as the holding library fills the holds (implemented in bug 15532). However, researchers have special privileges and are allowed to place on shelf holds. So, I guess my basic question is - can a third option on AllowOnShelfHolds work together with the ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold (bug 15532)? ----- How would the two sysprefs work together? I'll shorten "Allow on shelf holds" and "Allow hold if items available" as shelf_holds and allow_if_available here, for easier reference.) Say we have one bib, with two items. To me, it should work this way, if shelf_holds = no and allow_if_available = yes: a) No items checked out - no hold allowed. b) One item checked out (or more) - the checkout item(s) fills the hold when it is returned, the other items are unaffected. Testing his patch now this seem to be the case. The other way around is a little bit more problematic: shelf_holds = yes, allow_if_available = no. a) No items checked out - holds allowed. b) One item checked out – only the item available on the shelf should fill the hold. (A bit unsure about this one though, might require more thought.) Testing the patch, neither of these work – no holds are allowed until they are all checked out. The example Owen mentioned, when both sysprefs are set to no, and being able to place a hold when there are items available seems like a bug to me. I tried the same setting and was not allowed to place a hold... Setting both sysprefs = yes, should work as shelf_holds does today. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47805&action=ed… Bug 14097: Fixed missing test cases Fixed AllowPkiAuth issue caused by 15101. Added missing AudioAlerts TEST PLAN --------- 1) prove -v t/db_dependent/UsageStats.t -- should pass after applying patch 2) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #57 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47804&action=ed… Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #56 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47803&action=ed… Bug 14097 : Avoid issue if the number of syspref shared is modified Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #55 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47802&action=ed… Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0