February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #54 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47801&action=ed… Bug 14097: Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Now data is preserved, no errors. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47800&action=ed… Bug 14097: changing verif_systempreferences_values subroutine It's saving a large number of lines Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> All tests run, no koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #52 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47799&action=ed… Bug 14097: Delete table issues before testing If we delete all biblio DB, we could have some troubles with foreign keys Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46208|0 |1 is obsolete| | Attachment #46209|0 |1 is obsolete| | Attachment #46210|0 |1 is obsolete| | Attachment #46211|0 |1 is obsolete| | Attachment #47724|0 |1 is obsolete| | Attachment #47725|0 |1 is obsolete| | Attachment #47726|0 |1 is obsolete| | Attachment #47727|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47798&action=ed… Bug 14097: Testing C4::UsageStats DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47797&action=ed… Bug 15343 [QA Followup] * Check for leading/trailing spaces in password * Check hashed password in tests Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47796&action=ed… Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden Remove password confirmation field before submitting modification Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47795&action=ed… Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47407|0 |1 is obsolete| | Attachment #47408|0 |1 is obsolete| | Attachment #47409|0 |1 is obsolete| | Attachment #47705|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47794&action=ed… Bug 15343 - Allow user to set password on opac-memberentry.pl This patch allows patrons to create thier own password during OPAC self registration. It sets the password field to be hidden by default, and allows for a system generated password if no password is supplied and field is not mandatory 1 - Apply patch 2 - run updatedatabase.pl 3 - Check syspref "PatronSelfRegistrationBorrowerUnwantedField" - it should contain 'password' 4 - Check self registration on opac - there should be no change 5 - Remove 'password' from PatronSelfRegistrationBorrowerUnwantedField 6 - Password field should now be visible in OPAC self registration 7 - Register a patron: If no passwor is supplied you should get a system generated password 8 - Register a patron with a password, your password should be used 9 - Add 'password' to PatronSelfRegistrationBorrowerMnadatoryField 10 - Attempt to register a patron with no password - it should fail 11 - Try all combinations if mismatched/short/missing passwords and view correct error messages 12 - prove t/db_dependent/Members.t Sponsored by : Do Space (www.dospace.org) Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0