February 2016 - Koha-bugs - lists.koha-community.org

[Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47604|0 |1 is obsolete| | Attachment #47605|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47789&action=ed… bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47784|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47788&action=ed… Bug 15311 - Let libraries set text to display when OpacMaintenance = on Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online Moving code to atomic update and fixing merge conflict NOTE: Accounted for an SQL typo and autoescaping of the template. If someone else could test this, then I would be fine with marking it signed off. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13029] Allow to pass additional parameters to SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9021 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13029 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- My cellular provider does not provide this service, I am not able to test that the whole workflow works correctly. A few feedbacks anyway: 1/ It would be great to provide a Koha::Objects implementation for Koha::SMS::Provider 2/ SMSSendDriver is passed to the template in admin-home.pl, it's not necessary (use TT plugin instead) 3/ sms_providers.pl: use strict;use warnings; => use Modern::Perl; 4/ the ENGINE for the new table is not correct in the atomic update entry. 5/ You are create an index on a FK, it's not necessary: https://dev.mysql.com/doc/refman/5.7/en/create-table-foreign-keys.html Search for "Such an index is created on the referencing table automatically if it does not exist." 6/ When editing a patron, should not we hide the "sms provider" part if the sms number is not filled? 7/ When editing a provider, the selected line has a red background. We have the same behavior on smart-rules.pl and the background use is orange. It would make sense to have the same color. Marked as Failed QA for 2, 3, 4, 5 and 7 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Heather, Have you tested the CAS and Shibboleth authentication methods? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] change description of rental charges in account fines
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15282] Switch default CHECKIN notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '16

09 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Blocked by bug 14757. -- You are receiving this mail because: You are watching all bug changes.

1 0