February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15809] New: versions of CGI < 4.08 do not have multi_param
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Bug ID: 15809 Summary: versions of CGI < 4.08 do not have multi_param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named… http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applica… There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes.

1 42

[Bug 15853] New: Add author and link columns to opac course reserves table
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853 Bug ID: 15853 Summary: Add author and link columns to opac course reserves table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To be done: 1 - Add an author column to the opac course reserves table 2 - Add a 'link' column to the opac course reserves table, populated from the 856$u field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 15824] New: 'Done' button is unclear on batch item modification and deletion
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Bug ID: 15824 Summary: 'Done' button is unclear on batch item modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) Click edit -> Edit items in a batch Click Save (you don't need to make any changes) Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 15759] New: Allow Koha::Object derived objects to be used as hashrefs
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Bug ID: 15759 Summary: Allow Koha::Object derived objects to be used as hashrefs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object. This seems to be due to our long standing use of hashrefs for data in Koha. For instance, a developer may accidentally write: my $borrowernumber = $borrower->{borrowernumber}; instead of my $borrowernumber = $borrower->borrowernumber; Since our object is a blessed hashref, this does not cause an error. Instead, we just access that key of the hashref, which is almost certainly undefined. With some extra code in Koha/Object.pm, we can allow hashref-like use of our Objects, which will not only prevent these errors, but allow drop-in use of Koha::Objects where we currently use hashrefs! -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 15762] New: Fields editable in PatronSelfRegistrationBorrowerUnwantedField may be hidden by BorrowerUnwantedField
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15762 Bug ID: 15762 Summary: Fields editable in PatronSelfRegistrationBorrowerUnwantedField may be hidden by BorrowerUnwantedField Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It is possible for borrowers to create entries in their borrower record in the self registration process (as allowed by the system preference PatronSelfRegistrationBorrowerUnwantedField) that are hidden and un-editable via BorrowerUnwantedField. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15856] New: Serials Software error when saving new subscription
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15856 Bug ID: 15856 Summary: Serials Software error when saving new subscription Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: saidshafik(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Created attachment 48220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48220&action=ed… Screen shots of new subscription form entries, and software errors we got after Serials crashes When adding a new subscription, and after filling all fields on form, reviewing patterns, click on "Save", Serials crashes and gives the attached message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 15682] New: Merging records from cataloguing search only allows to merge 2 records
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 Bug ID: 15682 Summary: Merging records from cataloguing search only allows to merge 2 records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When merging from the list, you can now merge multiple records. But when merging from the cataloguing search, a javascript alert tells you that only 2 records can be selected for merging. Obviously... both should work the same and allow for multiple records to be merged at once. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 15927] New: Remove use of <tr class="highlight"> for alternating row colors.
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '16

15 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 Bug ID: 15927 Summary: Remove use of <tr class="highlight"> for alternating row colors. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org As a follow-up to the changes made in Bug 2889 we should clean up template which have markup like this: [% IF ( books_loo.toggle ) %] <tr class="highlight"> [% ELSE %] <tr> [% END %] ...with the goal of being able to remove the "highlight" class from staff-global.css or re-purpose it for a more specific highlighting task. staff-global.css line 267, "tbody tr:nth-child(odd) td" should eliminate the need for the highlight class. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15823] New: Can still access patron discharge slip without having the syspref on - Permissions breach
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Bug ID: 15823 Summary: Can still access patron discharge slip without having the syspref on - Permissions breach Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: Ensure that useDischarge syspref is off. Go to cgi-bin/koha/members/discharge.pl?borrowernumber=X Confirm that you are still able to access this page and generate discharge slip. This is a permissions breach -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 39

[Bug 15939] New: modification logs view now silently defaults to only current day's actions
by bugzilla-daemon＠bugs.koha-community.org 31 May '16

31 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Bug ID: 15939 Summary: modification logs view now silently defaults to only current day's actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org When accessing the modification logs from a link that does not explicitly set the to and from dates (e.g., from patron or bib details), no results are displayed unless the object had an action occur during the current day. This is a side-effect of commit 5dceb851 for bug 13813: In C4/Log.pm: - my $iso_datefrom = C4::Dates->new($datefrom,C4::Context->preference("dateformat"))->output('iso'); - my $iso_dateto = C4::Dates->new($dateto,C4::Context->preference("dateformat"))->output('iso'); + my $iso_datefrom = output_pref({ dt => dt_from_string( $datefrom ), dateformat => 'iso', dateonly => 1 }); + my $iso_dateto = output_pref({ dt => dt_from_string( $dateto ), dateformat => 'iso', dateonly => 1 }); In particular, C4::Dates->new($foo... returns undefined if $foo is undefined, whereas output_pref({ dt => dt_from_string( $foo... returns the current date. This amounts to a regression. -- You are receiving this mail because: You are watching all bug changes.

1 13